From: Mark Walters Date: Fri, 6 Sep 2013 23:28:45 +0000 (+0100) Subject: emacs: show: lazy part handling bugfix X-Git-Tag: 0.17_rc1~141 X-Git-Url: https://git.notmuchmail.org/git?a=commitdiff_plain;h=ee8305b519abe26f9a6cab5f67b782ddc95a7a7c;p=notmuch emacs: show: lazy part handling bugfix The lazy part handler had a bug that it allowed the button to be toggled to be specified. During toggling it needs to save and restore the text-properties for the button but it actually saved the text properties at point rather than from the button. In almost all cases this didn't matter as as point had the same text properties as the button. However, it is a bug and did cause incorrect behaviour in some cases: see id:87txhz14z6.fsf@qmul.ac.uk for details. --- diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 904b98e1..32c971a8 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -470,7 +470,7 @@ message at DEPTH in the current thread." (new-start (button-start button)) (button-label (button-get button :base-label)) (old-point (point)) - (properties (text-properties-at (point))) + (properties (text-properties-at (button-start button))) (inhibit-read-only t)) ;; Toggle the button itself. (button-put button :notmuch-part-hidden (not show))