From 4547ae5aa8fc7fd5d05da801c9fa9c055d39636f Mon Sep 17 00:00:00 2001
From: Anton Khirnov <anton@khirnov.net>
Date: Sat, 5 Jul 2025 17:18:16 +0200
Subject: [PATCH] test: add another known broken test for uncaught
 DatabaseModifiedError

This one is raised from _notmuch_message_create().

See also https://github.com/pazz/alot/issues/1460#issuecomment-2994101019
---
 test/T641-database-modified-messages.sh | 83 +++++++++++++++++++++++++
 1 file changed, 83 insertions(+)
 create mode 100755 test/T641-database-modified-messages.sh

diff --git a/test/T641-database-modified-messages.sh b/test/T641-database-modified-messages.sh
new file mode 100755
index 00000000..200a950d
--- /dev/null
+++ b/test/T641-database-modified-messages.sh
@@ -0,0 +1,83 @@
+#!/usr/bin/env bash
+test_description="handling DatabaseModifiedError from _notmuch_message_create"
+. $(dirname "$0")/test-lib.sh || exit 1
+
+# Triggering this exception is slightly magical. We need to
+# - first create a query, and from it a messages iterator
+# - then modify the database "enough"; it's not totally clear how much is
+#   enough, but adding the LKML corpus emails and doing some light tagging
+#   seems to work
+# - finally, iterate through the messages iterator, which should trigger the
+#   DatabaseModifiedError exception
+
+# add default corpus for the initial query
+add_email_corpus
+# As per above, copy LKML corpus email files, but do not add them to the DB yet.
+cp -a $NOTMUCH_SRCDIR/test/corpora/lkml ${MAIL_DIR}/
+
+test_begin_subtest "catching DatabaseModifiedError in _notmuch_message_create"
+test_subtest_known_broken
+
+test_C ${MAIL_DIR} <<EOF
+#include <notmuch-test.h>
+
+int
+main (int argc, char **argv)
+{
+    const char *path = argv[1];
+
+    notmuch_database_t *rw_db, *ro_db;
+    notmuch_messages_t *messages_ro, *messages_rw;
+    notmuch_query_t *query_ro, *query_rw;
+    char* msg = NULL;
+
+    EXPECT0 (notmuch_database_open_with_config (argv[1],
+						NOTMUCH_DATABASE_MODE_READ_ONLY,
+						"", NULL, &ro_db, &msg));
+    if (msg) fputs (msg, stderr);
+    assert (ro_db);
+
+    query_ro = notmuch_query_create (ro_db, "");
+    assert (query_ro);
+
+    EXPECT0 (notmuch_query_search_messages (query_ro, &messages_ro));
+
+    // index the previously copied LKML corpus files
+    EXPECT0 (system ("notmuch new --quiet"));
+
+    EXPECT0 (notmuch_database_open_with_config (argv[1],
+						NOTMUCH_DATABASE_MODE_READ_WRITE,
+						"", NULL, &rw_db, &msg));
+    if (msg) fputs (msg, stderr);
+
+    query_rw = notmuch_query_create (rw_db, "");
+    EXPECT0 (notmuch_query_search_messages (query_rw, &messages_rw));
+
+    for (;
+	 notmuch_messages_valid (messages_rw);
+	 notmuch_messages_move_to_next (messages_rw)) {
+	notmuch_message_t *message = notmuch_messages_get (messages_rw);
+	EXPECT0 (notmuch_message_add_tag (message, "tag"));
+    }
+
+    notmuch_database_close (rw_db);
+
+    for (;
+	 notmuch_messages_valid (messages_ro);
+	 notmuch_messages_move_to_next (messages_ro)) {
+	notmuch_message_t *message = notmuch_messages_get (messages_ro);
+    }
+
+    printf ("SUCCESS\n");
+    return 0;
+}
+EOF
+
+cat <<'EOF' >EXPECTED
+== stdout ==
+SUCCESS
+== stderr ==
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
+test_done
-- 
2.45.2