From 6d5deb76ca00fc2145aa9aaab6d3f87d2790020b Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 6 Mar 2021 09:49:32 -0400 Subject: [PATCH] lib/open: free value from g_key_file_get_value This fixes a small memory leak. --- lib/open.cc | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/lib/open.cc b/lib/open.cc index 4c08e9db..b28b64e8 100644 --- a/lib/open.cc +++ b/lib/open.cc @@ -153,7 +153,8 @@ _load_key_file (const char *path, } static notmuch_status_t -_choose_database_path (const char *config_path, +_choose_database_path (void *ctx, + const char *config_path, const char *profile, GKeyFile **key_file, const char **database_path, @@ -167,8 +168,13 @@ _choose_database_path (const char *config_path, return status; } - if (! *database_path && *key_file) - *database_path = g_key_file_get_value (*key_file, "database", "path", NULL); + if (! *database_path && *key_file) { + char *path = g_key_file_get_value (*key_file, "database", "path", NULL); + if (path) { + *database_path = talloc_strdup (ctx, path); + g_free (path); + } + } if (*database_path == NULL) { *message = strdup ("Error: Cannot open a database for a NULL path.\n"); @@ -201,7 +207,8 @@ notmuch_database_open_with_config (const char *database_path, GKeyFile *key_file = NULL; static int initialized = 0; - if ((status = _choose_database_path (config_path, profile, &key_file, &database_path, &message))) + if ((status = _choose_database_path (local, config_path, profile, &key_file, &database_path, + &message))) goto DONE; if (! (notmuch_path = talloc_asprintf (local, "%s/%s", database_path, ".notmuch"))) { @@ -427,7 +434,8 @@ notmuch_database_create_with_config (const char *database_path, int err; void *local = talloc_new (NULL); - if ((status = _choose_database_path (config_path, profile, &key_file, &database_path, &message))) + if ((status = _choose_database_path (local, config_path, profile, &key_file, &database_path, + &message))) goto DONE; err = stat (database_path, &st); -- 2.43.0