git.notmuchmail.org Git - notmuch/blob - test/corpora/lkml/cur/1382298587.002228:2,

   1 From: Scott Lovenberg <scott.lovenberg@gmail.com>
   2 Subject: Re: [RFC][PATCH 10/10] cifs: add mount option to enable local caching
   3 Date: Wed, 23 Jun 2010 14:32:24 -0400
   4 Lines: 37
   5 Message-ID: <4C225338.9010807@gmail.com>
   6 References: <yes> <1277220309-3757-1-git-send-email-sjayaraman@suse.de>
   7 Mime-Version: 1.0
   8 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
   9 Content-Transfer-Encoding: 7bit
  10 Cc: Steve French <smfrench@gmail.com>, linux-cifs@vger.kernel.org,
  11         linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
  12         David Howells <dhowells@redhat.com>
  13 To: Suresh Jayaraman <sjayaraman@suse.de>
  14 X-From: linux-kernel-owner@vger.kernel.org Wed Jun 23 20:32:44 2010
  15 Return-path: <linux-kernel-owner@vger.kernel.org>
  16 Envelope-to: glk-linux-kernel-3@lo.gmane.org
  17 Received: from vger.kernel.org ([209.132.180.67])
  18         by lo.gmane.org with esmtp (Exim 4.69)
  19         (envelope-from <linux-kernel-owner@vger.kernel.org>)
  20         id 1ORUke-00020X-7B
  21         for glk-linux-kernel-3@lo.gmane.org; Wed, 23 Jun 2010 20:32:44 +0200
  22 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
  23         id S1753205Ab0FWScd (ORCPT <rfc822;glk-linux-kernel-3@m.gmane.org>);
  24         Wed, 23 Jun 2010 14:32:33 -0400
  25 Received: from mail-gx0-f174.google.com ([209.85.161.174]:50118 "EHLO
  26         mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
  27         with ESMTP id S1752380Ab0FWScb (ORCPT
  28         <rfc822;linux-kernel@vger.kernel.org>);
  29         Wed, 23 Jun 2010 14:32:31 -0400
  30 Received: by gxk28 with SMTP id 28so317656gxk.19
  31         for <multiple recipients>; Wed, 23 Jun 2010 11:32:31 -0700 (PDT)
  32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  33         d=gmail.com; s=gamma;
  34         h=domainkey-signature:received:received:message-id:date:from
  35          :user-agent:mime-version:to:cc:subject:references:in-reply-to
  36          :content-type:content-transfer-encoding;
  37         bh=iTBSrajJefJVTimpUcvJQmptYefXJDrz9ZyZgxnMvzA=;
  38         b=DOZLux9YGwNIWknqofz5rMltvopOT+kRgPsHIYw8Z7Uhh9gR5YAD4V6kKmv1SIaWoo
  39          uXjNwY+IPIiD4f4OwwlpwJTd4B7PkBCDIlOkwVcvvS3F6qr6WbXBd0nRuRiFGMwONU3E
  40          MqTAWDDwIXLVURr1t+n3MFrKwKj5b7pZT5fHw=
  41 DomainKey-Signature: a=rsa-sha1; c=nofws;
  42         d=gmail.com; s=gamma;
  43         h=message-id:date:from:user-agent:mime-version:to:cc:subject
  44          :references:in-reply-to:content-type:content-transfer-encoding;
  45         b=pTsfPMlTDpE3Oi2w9V3eE2ohOeBEloXhgElmCwGEenBegF7ZhIyoga6tyRJqQ922ws
  46          oyxLXSORpOuPJRoIBRXfzae3KXkgKT0eLDjxQNTdS7Jbe+vcJ604sANFcnxBsJ51fThT
  47          R/wXt7LiG/T6H4DUpcN7aUjtzlq9JgC2JQ/ws=
  48 Received: by 10.224.43.197 with SMTP id x5mr5243425qae.127.1277317950764;
  49         Wed, 23 Jun 2010 11:32:30 -0700 (PDT)
  50 Received: from [192.168.0.2] ([64.9.41.61])
  51         by mx.google.com with ESMTPS id 15sm3010007qcg.2.2010.06.23.11.32.25
  52         (version=TLSv1/SSLv3 cipher=RC4-MD5);
  53         Wed, 23 Jun 2010 11:32:26 -0700 (PDT)
  54 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.10) Gecko/20100512 Lightning/1.0b1 Thunderbird/3.0.5 ThunderBrowse/3.2.8.1
  55 In-Reply-To: <1277220309-3757-1-git-send-email-sjayaraman@suse.de>
  56 Sender: linux-kernel-owner@vger.kernel.org
  57 Precedence: bulk
  58 List-ID: <linux-kernel.vger.kernel.org>
  59 X-Mailing-List: linux-kernel@vger.kernel.org
  60 Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1002258>
  61
  62 On 6/22/2010 11:25 AM, Suresh Jayaraman wrote:
  63 > Add a mount option 'fsc' to enable local caching on CIFS.
  64 >
  65 > As the cifs-utils (userspace) changes are not done yet, this patch enables
  66 > 'fsc' by default to assist testing.
  67 >
  68 [...]
  69 > @@ -1332,6 +1336,8 @@ cifs_parse_mount_options(char *options, const char *devname,
  70 >                       printk(KERN_WARNING "CIFS: Mount option noac not "
  71 >                               "supported. Instead set "
  72 >                               "/proc/fs/cifs/LookupCacheEnabled to 0\n");
  73 > +             } else if (strnicmp(data, "fsc", 3) == 0) {
  74 > +                     vol->fsc = true;
  75 >               } else
  76 >                       printk(KERN_WARNING "CIFS: Unknown mount option %s\n",
  77 >                                               data);
  78 > @@ -2405,6 +2411,8 @@ static void setup_cifs_sb(struct smb_vol *pvolume_info,
  79 >               cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_OVERR_GID;
  80 >       if (pvolume_info->dynperm)
  81 >               cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_DYNPERM;
  82 > +     if (pvolume_info->fsc)
  83 > +             cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_FSCACHE;
  84 >       if (pvolume_info->direct_io) {
  85 >               cFYI(1, "mounting share using direct i/o");
  86 >               cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_DIRECT_IO;
  87 >
  88 I reworked the CIFS mount option parsing a while back; I'm not sure
  89 whether that patch was going to be in the 2.6.35 tree or not (the window
  90 just opened, didn't it?).
  91
  92 Jeff, Steve, can you confirm if that patch is going to be in 2.6.35?
  93
  94 Patch refs: http://patchwork.ozlabs.org/patch/53059/  and
  95 http://patchwork.ozlabs.org/patch/53674/
  96
  97
  98
  99
 100