git.notmuchmail.org Git - notmuch/blob - test/corpora/lkml/cur/1382298770.002189:2,

   1 From: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
   2 Subject: Re: [RFC][PATCH 03/10] cifs: register CIFS for caching
   3 Date: Wed, 23 Jun 2010 17:51:17 +0100
   4 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
   5         Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
   6         Kingdom.
   7         Registered in England and Wales under Company Registration No. 3798903
   8 Lines: 20
   9 Message-ID: <9603.1277311877@redhat.com>
  10 References: <1277220189-3485-1-git-send-email-sjayaraman@suse.de> <yes>
  11 Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
  12         linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
  13         linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
  14 To: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
  15 X-From: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Wed Jun 23 18:51:32 2010
  16 Return-path: <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
  17 Envelope-to: glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org
  18 Received: from vger.kernel.org ([209.132.180.67])
  19         by lo.gmane.org with esmtp (Exim 4.69)
  20         (envelope-from <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>)
  21         id 1ORTAg-0008Bt-CT
  22         for glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org; Wed, 23 Jun 2010 18:51:30 +0200
  23 Received: (majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org) by vger.kernel.org via listexpand
  24         id S1751915Ab0FWQv3 (ORCPT <rfc822;glkc-linux-cifs@m.gmane.org>);
  25         Wed, 23 Jun 2010 12:51:29 -0400
  26 Received: from mx1.redhat.com ([209.132.183.28]:50923 "EHLO mx1.redhat.com"
  27         rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
  28         id S1751520Ab0FWQv3 (ORCPT <rfc822;linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>);
  29         Wed, 23 Jun 2010 12:51:29 -0400
  30 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
  31         by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5NGpLFc028550
  32         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
  33         Wed, 23 Jun 2010 12:51:21 -0400
  34 Received: from redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])
  35         by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5NGpHIG010890;
  36         Wed, 23 Jun 2010 12:51:18 -0400
  37 In-Reply-To: <1277220189-3485-1-git-send-email-sjayaraman-l3A5Bk7waGM@public.gmane.org>
  38 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18
  39 Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
  40 Precedence: bulk
  41 List-ID: <linux-cifs.vger.kernel.org>
  42 X-Mailing-List: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
  43 Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1002219>
  44
  45 Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org> wrote:
  46
  47 > +     rc = cifs_fscache_register();
  48 > +     if (rc)
  49 > +             goto out;
  50 > +
  51 >       rc = cifs_init_inodecache();
  52 >       if (rc)
  53 >               goto out_clean_proc;
  54 > @@ -949,8 +954,10 @@ init_cifs(void)
  55 >       cifs_destroy_mids();
  56 >   out_destroy_inodecache:
  57 >       cifs_destroy_inodecache();
  58 > +     cifs_fscache_unregister();
  59 >   out_clean_proc:
  60
  61 This is incorrect.  You need to call cifs_fscache_unregister() if
  62 cifs_init_inodecache() fails.
  63
  64 David
  65
  66