git.notmuchmail.org Git - notmuch/blob - test/corpora/lkml/cur/1382298770.002879:2,

   1 From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
   2 Subject: Re: [RFC][PATCH 03/10] cifs: register CIFS for caching
   3 Date: Fri, 25 Jun 2010 16:26:22 +0530
   4 Lines: 26
   5 Message-ID: <4C248B56.8030207@suse.de>
   6 References: <1277220189-3485-1-git-send-email-sjayaraman@suse.de> <yes> <9603.1277311877@redhat.com>
   7 Mime-Version: 1.0
   8 Content-Type: text/plain; charset=UTF-8
   9 Content-Transfer-Encoding: 7bit
  10 Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
  11         linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
  12 To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  13 X-From: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Fri Jun 25 12:56:32 2010
  14 Return-path: <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
  15 Envelope-to: glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org
  16 Received: from vger.kernel.org ([209.132.180.67])
  17         by lo.gmane.org with esmtp (Exim 4.69)
  18         (envelope-from <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>)
  19         id 1OS6aG-00066f-1L
  20         for glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org; Fri, 25 Jun 2010 12:56:32 +0200
  21 Received: (majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org) by vger.kernel.org via listexpand
  22         id S1754188Ab0FYK4b (ORCPT <rfc822;glkc-linux-cifs@m.gmane.org>);
  23         Fri, 25 Jun 2010 06:56:31 -0400
  24 Received: from cantor.suse.de ([195.135.220.2]:46564 "EHLO mx1.suse.de"
  25         rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
  26         id S1753651Ab0FYK4a (ORCPT <rfc822;linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>);
  27         Fri, 25 Jun 2010 06:56:30 -0400
  28 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2])
  29         (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
  30         (No client certificate requested)
  31         by mx1.suse.de (Postfix) with ESMTP id 17F1E6CB00;
  32         Fri, 25 Jun 2010 12:56:30 +0200 (CEST)
  33 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0
  34 In-Reply-To: <9603.1277311877-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  35 Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
  36 Precedence: bulk
  37 List-ID: <linux-cifs.vger.kernel.org>
  38 X-Mailing-List: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
  39 Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1002913>
  40
  41 On 06/23/2010 10:21 PM, David Howells wrote:
  42 > Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org> wrote:
  43 >
  44 >> +    rc = cifs_fscache_register();
  45 >> +    if (rc)
  46 >> +            goto out;
  47 >> +
  48 >>      rc = cifs_init_inodecache();
  49 >>      if (rc)
  50 >>              goto out_clean_proc;
  51 >> @@ -949,8 +954,10 @@ init_cifs(void)
  52 >>      cifs_destroy_mids();
  53 >>   out_destroy_inodecache:
  54 >>      cifs_destroy_inodecache();
  55 >> +    cifs_fscache_unregister();
  56 >>   out_clean_proc:
  57 >
  58 > This is incorrect.  You need to call cifs_fscache_unregister() if
  59 > cifs_init_inodecache() fails.
  60 >
  61
  62 Doh! I'll fix it.
  63
  64
  65 --
  66 Suresh Jayaraman
  67
  68