git.notmuchmail.org Git - notmuch/blob - test/corpora/lkml/cur/1382298793.003013:2,

   1 From: Mark Brown <broonie@opensource.wolfsonmicro.com>
   2 Subject: Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary
   3         semicolons
   4 Date: Tue, 16 Nov 2010 10:49:22 +0000
   5 Lines: 50
   6 Message-ID: <20101116104921.GL12986@rakim.wolfsonmicro.main>
   7 References: <20101115134939.GC12986@rakim.wolfsonmicro.main>
   8         <1289840957.16461.138.camel@Joe-Laptop>
   9         <20101115173031.GI12986@rakim.wolfsonmicro.main>
  10         <1289842444.16461.140.camel@Joe-Laptop>
  11         <20101115182708.GJ12986@rakim.wolfsonmicro.main>
  12         <1289845830.16461.149.camel@Joe-Laptop>
  13         <20101115190738.GF3338@sirena.org.uk>
  14         <1289848458.16461.150.camel@Joe-Laptop>
  15         <20101115193407.GK12986@rakim.wolfsonmicro.main>
  16         <1289850773.16461.166.camel@Joe-Laptop>
  17 Mime-Version: 1.0
  18 Content-Type: text/plain; charset="us-ascii"
  19 Content-Transfer-Encoding: 7bit
  20 Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
  21         alsa-devel@alsa-project.org, Jiri Kosina <trivial@kernel.org>,
  22         Takashi Iwai <tiwai@suse.de>, linux-kernel@vger.kernel.org,
  23         Ian Lartey <ian@opensource.wolfsonmicro.com>,
  24         Liam Girdwood <lrg@slimlogic.co.uk>
  25 To: Joe Perches <joe@perches.com>
  26 X-From: alsa-devel-bounces@alsa-project.org Tue Nov 16 11:49:29 2010
  27 Return-path: <alsa-devel-bounces@alsa-project.org>
  28 Envelope-to: glad-alsa-devel-2@m.gmane.org
  29 Received: from alsa0.perex.cz ([212.20.107.51])
  30         by lo.gmane.org with esmtp (Exim 4.69)
  31         (envelope-from <alsa-devel-bounces@alsa-project.org>)
  32         id 1PIJ6O-0003Hl-Gx
  33         for glad-alsa-devel-2@m.gmane.org; Tue, 16 Nov 2010 11:49:28 +0100
  34 Received: by alsa0.perex.cz (Postfix, from userid 1000)
  35         id C3B89243EB; Tue, 16 Nov 2010 11:49:27 +0100 (CET)
  36 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on mail1.perex.cz
  37 X-Spam-Level:
  38 X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled
  39         version=3.2.4
  40 Received: from alsa0.perex.cz (localhost [127.0.0.1])
  41         by alsa0.perex.cz (Postfix) with ESMTP id 5204E243EB;
  42         Tue, 16 Nov 2010 11:49:26 +0100 (CET)
  43 X-Original-To: alsa-devel@alsa-project.org
  44 Delivered-To: alsa-devel@alsa-project.org
  45 Received: by alsa0.perex.cz (Postfix, from userid 1000)
  46         id D1E2E243EC; Tue, 16 Nov 2010 11:49:24 +0100 (CET)
  47 Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com
  48         [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 16268243EA
  49         for <alsa-devel@alsa-project.org>; Tue, 16 Nov 2010 11:49:24 +0100 (CET)
  50 Received: from rakim.wolfsonmicro.main (lumison.wolfsonmicro.com
  51         [87.246.78.27])
  52         by opensource2.wolfsonmicro.com (Postfix) with ESMTPSA id 4AC4E3B438A;
  53         Tue, 16 Nov 2010 10:49:23 +0000 (GMT)
  54 Received: from broonie by rakim.wolfsonmicro.main with local (Exim 4.72)
  55         (envelope-from <broonie@rakim.wolfsonmicro.main>)
  56         id 1PIJ6I-0001Kz-Cf; Tue, 16 Nov 2010 10:49:22 +0000
  57 Content-Disposition: inline
  58 In-Reply-To: <1289850773.16461.166.camel@Joe-Laptop>
  59 X-Cookie: I like your SNOOPY POSTER!!
  60 User-Agent: Mutt/1.5.20 (2009-06-14)
  61 X-BeenThere: alsa-devel@alsa-project.org
  62 X-Mailman-Version: 2.1.9
  63 Precedence: list
  64 List-Id: "Alsa-devel mailing list for ALSA developers -
  65         http://www.alsa-project.org" <alsa-devel.alsa-project.org>
  66 List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
  67         <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
  68 List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
  69 List-Post: <mailto:alsa-devel@alsa-project.org>
  70 List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
  71 List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
  72         <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
  73 Sender: alsa-devel-bounces@alsa-project.org
  74 Errors-To: alsa-devel-bounces@alsa-project.org
  75 Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1063040>
  76
  77 On Mon, Nov 15, 2010 at 11:52:53AM -0800, Joe Perches wrote:
  78 > On Mon, 2010-11-15 at 19:34 +0000, Mark Brown wrote:
  79
  80 > > It appears your scripts are already hooked into get_maintainers.pl which
  81 > > would seem the obvious place to do this?  Sadly I don't do perl, though
  82 > > it looks like you're doing pretty much all the work on that anyway.
  83
  84 > Sadly, no it's not the right place.
  85
  86 To query MAINTAINERS?  I'd assume that's where you'd want to put that
  87 stuff?
  88
  89 > There could be a modification to $1 (path)
  90 > or some such.
  91 >
  92 > Maybe a script like
  93 > ./scripts/convert_commit_subject_to_subsystem_maintainer_taste
  94 > or something.
  95
  96 > Care to write one in sh/bash/perl/python/c/ocaml/c#?
  97
  98 Like I say I'd expect this to be a get_maintainers based lookup to dump
  99 some data out?
 100
 101 > As far as I know, the only subsystem pedants^H^H^H^H^Hople
 102 > that care much about the commit subject style are
 103 > arch/x86 and sound.
 104
 105 If you look at the kernel you'll see quite a few subsystems which have
 106 some sort of standard practice which they do try to enforce, you
 107 shouldn't take silence as people being happy here - it's taken me some
 108 considerable time to get round to mentioning this, for example, and I
 109 might not have bothered if the patch had applied first time around.
 110 Like working against -next it's one of these things that would make your
 111 patches easier to deal with.
 112
 113 > I can understand the desire of these subsystem maintainers
 114 > to have a consistent style.  I think though that requiring
 115 > a subject header style without providing more than a
 116 > general guideline is a but much.
 117
 118 The general guideline I tend to go with is that if what you're doing
 119 looks odd for the code you're submitting against for some reason you're
 120 doing something wrong unless you understand why you're doing something
 121 different and there's a good reason.
 122
 123 > I'd use any other automated tool you want to provide.
 124
 125 Like I say, I'd expect the lookup from the database to be handled by
 126 get_maintainers.pl.  Having a separate database would seem odd.
 127
 128