git.notmuchmail.org Git - notmuch/blob - test/corpora/lkml/cur/1382298805.004642:2,

   1 From: Ingo Molnar <mingo@elte.hu>
   2 Subject: Re: [PATCH 1/6] x86: move ioapic_irq_destination_types
   3 Date: Mon, 14 Feb 2011 12:05:28 +0100
   4 Lines: 40
   5 Message-ID: <20110214110528.GD7140@elte.hu>
   6 References: <1297677612-12405-1-git-send-email-henne@nachtwindheim.de>
   7 Mime-Version: 1.0
   8 Content-Type: text/plain; charset=us-ascii
   9 Cc: mingo@readhat.com, tglx@linutronix.de, hpa@zytor.com,
  10         x86@kernel.org, tj@kernel.org, yinghai@kernel.org,
  11         ak@linux.intel.com, robert.richter@amd.com,
  12         linux-kernel@vger.kernel.org
  13 To: Henrik Kretzschmar <henne@nachtwindheim.de>
  14 X-From: linux-kernel-owner@vger.kernel.org Mon Feb 14 12:06:00 2011
  15 Return-path: <linux-kernel-owner@vger.kernel.org>
  16 Envelope-to: glk-linux-kernel-3@lo.gmane.org
  17 Received: from vger.kernel.org ([209.132.180.67])
  18         by lo.gmane.org with esmtp (Exim 4.69)
  19         (envelope-from <linux-kernel-owner@vger.kernel.org>)
  20         id 1PowFj-0003bW-W9
  21         for glk-linux-kernel-3@lo.gmane.org; Mon, 14 Feb 2011 12:06:00 +0100
  22 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
  23         id S1753317Ab1BNLFq (ORCPT <rfc822;glk-linux-kernel-3@m.gmane.org>);
  24         Mon, 14 Feb 2011 06:05:46 -0500
  25 Received: from mx3.mail.elte.hu ([157.181.1.138]:46158 "EHLO mx3.mail.elte.hu"
  26         rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
  27         id S1752958Ab1BNLFn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
  28         Mon, 14 Feb 2011 06:05:43 -0500
  29 Received: from elvis.elte.hu ([157.181.1.14])
  30         by mx3.mail.elte.hu with esmtp (Exim)
  31         id 1PowFH-0003wc-2d
  32         from <mingo@elte.hu>; Mon, 14 Feb 2011 12:05:36 +0100
  33 Received: by elvis.elte.hu (Postfix, from userid 1004)
  34         id 30C323E2369; Mon, 14 Feb 2011 12:05:27 +0100 (CET)
  35 Content-Disposition: inline
  36 In-Reply-To: <1297677612-12405-1-git-send-email-henne@nachtwindheim.de>
  37 User-Agent: Mutt/1.5.20 (2009-08-17)
  38 Received-SPF: neutral (mx3: 157.181.1.14 is neither permitted nor denied by domain of elte.hu) client-ip=157.181.1.14; envelope-from=mingo@elte.hu; helo=elvis.elte.hu;
  39 X-ELTE-SpamScore: -2.0
  40 X-ELTE-SpamLevel:
  41 X-ELTE-SpamCheck: no
  42 X-ELTE-SpamVersion: ELTE 2.0
  43 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5
  44         -2.0 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
  45         [score: 0.0000]
  46 Sender: linux-kernel-owner@vger.kernel.org
  47 Precedence: bulk
  48 List-ID: <linux-kernel.vger.kernel.org>
  49 X-Mailing-List: linux-kernel@vger.kernel.org
  50 Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1099674>
  51
  52
  53 * Henrik Kretzschmar <henne@nachtwindheim.de> wrote:
  54
  55 > +++ b/arch/x86/include/asm/apicdef.h
  56 > @@ -426,4 +426,16 @@ struct local_apic {
  57 >  #else
  58 >   #define BAD_APICID 0xFFFFu
  59 >  #endif
  60 > +
  61 > +enum ioapic_irq_destination_types {
  62 > +     dest_Fixed = 0,
  63 > +     dest_LowestPrio = 1,
  64 > +     dest_SMI = 2,
  65 > +     dest__reserved_1 = 3,
  66 > +     dest_NMI = 4,
  67 > +     dest_INIT = 5,
  68 > +     dest__reserved_2 = 6,
  69 > +     dest_ExtINT = 7
  70 > +};
  71
  72 one very small request, while we are moving it could you please align the value
  73 enumeration vertically? Something like:
  74
  75 enum ioapic_irq_destination_types {
  76
  77         dest_Fixed              = 0,
  78         dest_LowestPrio         = 1,
  79         dest_SMI                = 2,
  80         dest__reserved_1        = 3,
  81         dest_NMI                = 4,
  82         dest_INIT               = 5,
  83         dest__reserved_2        = 6,
  84         dest_ExtINT             = 7
  85 };
  86
  87 ... would be much more readable, right?
  88
  89 Thanks,
  90
  91         Ingo
  92
  93