From: Michael Neuling Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port Date: Tue, 03 Aug 2010 16:06:30 +1000 Lines: 15 Message-ID: <4381.1280815590@neuling.org> References: <20100308191005.GE4324@amak.tundra.com> Cc: Alexandre Bounine , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, thomas.moll@sysgo.com To: Timur Tabi X-From: linux-kernel-owner@vger.kernel.org Tue Aug 03 08:06:45 2010 Return-path: Envelope-to: glk-linux-kernel-3@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OgAeD-00087x-ED for glk-linux-kernel-3@lo.gmane.org; Tue, 03 Aug 2010 08:06:45 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755287Ab0HCGGf (ORCPT ); Tue, 3 Aug 2010 02:06:35 -0400 Received: from ozlabs.org ([203.10.76.45]:51158 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755139Ab0HCGGd (ORCPT ); Tue, 3 Aug 2010 02:06:33 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id B7A371007D1; Tue, 3 Aug 2010 16:06:31 +1000 (EST) Received: by localhost.localdomain (Postfix, from userid 1000) id EDBB7C5EB7; Tue, 3 Aug 2010 16:06:30 +1000 (EST) Received: from neuling.org (localhost [127.0.0.1]) by localhost.localdomain (Postfix) with ESMTP id E8003C51D3; Tue, 3 Aug 2010 16:06:30 +1000 (EST) In-reply-to: Comments: In-reply-to Timur Tabi message dated "Wed, 30 Jun 2010 16:00:56 -0500." X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.1.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Archived-At: > > MCSR_MASK is not defined anywhere, so when I compile this code, I get this: > > Never mind. I see that it's been fixed already, and that the patch > that removed MCSR_MASK was posted around the same time that this patch > was posted. I don't know what happened here but 2.6.35 is broken because of this problem: arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared (first use in this function) arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier is reported only once arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears in.) arch/powerpc/sysdev/fsl_rio.c:250: error: 'MCSR_BUS_RBERR' undeclared (first use in this function) Mikey