From: Michael Neuling Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port Date: Thu, 05 Aug 2010 13:34:20 +1000 Lines: 50 Message-ID: <26581.1280979260@neuling.org> References: <20100308191005.GE4324@amak.tundra.com> <4381.1280815590@neuling.org> <0CE8B6BE3C4AD74AB97D9D29BD24E5520114309D@CORPEXCH1.na.ads.idt.com> <0CE8B6BE3C4AD74AB97D9D29BD24E552011430BC@CORPEXCH1.na.ads.idt.com> Cc: "Timur Tabi" , "Alexandre Bounine" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, thomas.moll@sysgo.com, "Kumar Gala" To: "Bounine, Alexandre" X-From: linux-kernel-owner@vger.kernel.org Thu Aug 05 05:34:37 2010 Return-path: Envelope-to: glk-linux-kernel-3@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OgrE1-00024O-Bh for glk-linux-kernel-3@lo.gmane.org; Thu, 05 Aug 2010 05:34:33 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758775Ab0HEDeX (ORCPT ); Wed, 4 Aug 2010 23:34:23 -0400 Received: from ozlabs.org ([203.10.76.45]:40810 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758704Ab0HEDeV (ORCPT ); Wed, 4 Aug 2010 23:34:21 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 97995B70D8; Thu, 5 Aug 2010 13:34:20 +1000 (EST) Received: by localhost.localdomain (Postfix, from userid 1000) id 456CDCC199; Thu, 5 Aug 2010 13:34:20 +1000 (EST) Received: from neuling.org (localhost [127.0.0.1]) by localhost.localdomain (Postfix) with ESMTP id 404C8C6123; Thu, 5 Aug 2010 13:34:20 +1000 (EST) In-reply-to: <0CE8B6BE3C4AD74AB97D9D29BD24E552011430BC@CORPEXCH1.na.ads.idt.com> Comments: In-reply-to "Bounine, Alexandre" message dated "Tue, 03 Aug 2010 06:24:47 -0700." X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.1.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Archived-At: In message <0CE8B6BE3C4AD74AB97D9D29BD24E552011430BC@CORPEXCH1.na.ads.idt.com> you wrote: > Yang Li pointed to these patches in his post from July 23, 2010. > It would be nice to have these patches in mainline code.=20 This is still broken in Kumar's latest tree. Do you guys wanna repost them so Kumar can pick them up easily? Mikey > > > -----Original Message----- > > From: timur.tabi@gmail.com [mailto:timur.tabi@gmail.com] On Behalf Of > Timur Tabi > > Sent: Tuesday, August 03, 2010 9:02 AM > > To: Bounine, Alexandre > > Cc: Michael Neuling; Alexandre Bounine; linuxppc-dev@lists.ozlabs.org; > linux-kernel@vger.kernel.org; > > thomas.moll@sysgo.com; Kumar Gala > > Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO > port > >=20 > > On Tue, Aug 3, 2010 at 7:17 AM, Bounine, Alexandre > > wrote: > > > This happened after change to book-e definitions. > > > There are patches that address this issue. > >=20 > > And those patches should have been applied before 2.6.35 was released. > > Someone dropped the ball. 2.6.35 is broken for a number of PowerPC > > boards: > >=20 > > $ make mpc85xx_defconfig > > .... > > $ make > > .... > > CC arch/powerpc/sysdev/fsl_rio.o > > arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': > > arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared > > (first use in this function) > > arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier > > is reported only once > > arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears > in.) > > make[1]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1 > >=20 > > -- > > Timur Tabi > > Linux kernel developer at Freescale >