crypto: make crypto ctx initialization an array

[notmuch] / crypto.c

diff --git a/crypto.c b/crypto.c
index fbe5aeb6b3968168bb9cdd95bf3269f42b53b4ed..da0289dcf392db8b9277d0a9fa5dbca9bd3a2f86 100644 (file)
--- a/crypto.c
+++ b/crypto.c
@@ -20,12 +20,55 @@
 
 #include "notmuch-client.h"
 
+/* Create a GPG context (GMime 2.6) */
+static notmuch_crypto_context_t *
+create_gpg_context (notmuch_crypto_t *crypto)
+{
+    notmuch_crypto_context_t *gpgctx;
+
+    if (crypto->gpgctx)
+       return crypto->gpgctx;
+
+    /* TODO: GMimePasswordRequestFunc */
+    gpgctx = g_mime_gpg_context_new (NULL, crypto->gpgpath ? crypto->gpgpath : "gpg");
+    if (! gpgctx) {
+       fprintf (stderr, "Failed to construct gpg context.\n");
+       return NULL;
+    }
+    crypto->gpgctx = gpgctx;
+
+    g_mime_gpg_context_set_use_agent ((GMimeGpgContext *) gpgctx, TRUE);
+    g_mime_gpg_context_set_always_trust ((GMimeGpgContext *) gpgctx, FALSE);
+
+    return gpgctx;
+}
+
+static const struct {
+    const char *protocol;
+    notmuch_crypto_context_t *(*get_context) (notmuch_crypto_t *crypto);
+} protocols[] = {
+    {
+       .protocol = "application/pgp-signature",
+       .get_context = create_gpg_context,
+    },
+    {
+       .protocol = "application/pgp-encrypted",
+       .get_context = create_gpg_context,
+    },
+};
+
 /* for the specified protocol return the context pointer (initializing
  * if needed) */
 notmuch_crypto_context_t *
 notmuch_crypto_get_context (notmuch_crypto_t *crypto, const char *protocol)
 {
     notmuch_crypto_context_t *cryptoctx = NULL;
+    size_t i;
+
+    if (! protocol) {
+       fprintf (stderr, "Cryptographic protocol is empty.\n");
+       return cryptoctx;
+    }
 
     /* As per RFC 1847 section 2.1: "the [protocol] value token is
      * comprised of the type and sub-type tokens of the Content-Type".
@@ -33,30 +76,14 @@ notmuch_crypto_get_context (notmuch_crypto_t *crypto, const char *protocol)
      * parameter names as defined in this document are
      * case-insensitive."  Thus, we use strcasecmp for the protocol.
      */
-    if ((strcasecmp (protocol, "application/pgp-signature") == 0)
-       || (strcasecmp (protocol, "application/pgp-encrypted") == 0)) {
-       if (!crypto->gpgctx) {
-#ifdef GMIME_ATLEAST_26
-           /* TODO: GMimePasswordRequestFunc */
-           crypto->gpgctx = g_mime_gpg_context_new (NULL, "gpg");
-#else
-           GMimeSession* session = g_object_new (g_mime_session_get_type(), NULL);
-           crypto->gpgctx = g_mime_gpg_context_new (session, "gpg");
-           g_object_unref (session);
-#endif
-           if (crypto->gpgctx) {
-               g_mime_gpg_context_set_always_trust ((GMimeGpgContext*) crypto->gpgctx, FALSE);
-           } else {
-               fprintf (stderr, "Failed to construct gpg context.\n");
-           }
-       }
-       cryptoctx = crypto->gpgctx;
-
-    } else {
-       fprintf (stderr, "Unknown or unsupported cryptographic protocol.\n");
+    for (i = 0; i < ARRAY_SIZE (protocols); i++) {
+       if (strcasecmp (protocol, protocols[i].protocol) == 0)
+           return protocols[i].get_context (crypto);
     }
 
-    return cryptoctx;
+    fprintf (stderr, "Unknown or unsupported cryptographic protocol.\n");
+
+    return NULL;
 }
 
 int