util: Fix two corner-cases in boolean term quoting function

[notmuch] / notmuch-dump.c

diff --git a/notmuch-dump.c b/notmuch-dump.c
index d2dad40da22f2943545aa475d178e65d1e29c79b..158142f55b4992c53de1396e7e557536b9074ec8 100644 (file)
--- a/notmuch-dump.c
+++ b/notmuch-dump.c
@@ -20,11 +20,11 @@
 
 #include "notmuch-client.h"
 #include "dump-restore-private.h"
+#include "string-util.h"
 
 int
-notmuch_dump_command (unused (void *ctx), int argc, char *argv[])
+notmuch_dump_command (notmuch_config_t *config, int argc, char *argv[])
 {
-    notmuch_config_t *config;
     notmuch_database_t *notmuch;
     notmuch_query_t *query;
     FILE *output = stdout;
@@ -33,18 +33,14 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[])
     notmuch_tags_t *tags;
     const char *query_str = "";
 
-    config = notmuch_config_open (ctx, NULL, NULL);
-    if (config == NULL)
-       return 1;
-
     if (notmuch_database_open (notmuch_config_get_database_path (config),
                               NOTMUCH_DATABASE_MODE_READ_ONLY, &notmuch))
-       return 1;
+       return EXIT_FAILURE;
 
     char *output_file_name = NULL;
     int opt_index;
 
-    int output_format = DUMP_FORMAT_SUP;
+    int output_format = DUMP_FORMAT_BATCH_TAG;
 
     notmuch_opt_desc_t options[] = {
        { NOTMUCH_OPT_KEYWORD, &output_format, "format", 'f',
@@ -56,18 +52,15 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[])
     };
 
     opt_index = parse_arguments (argc, argv, options, 1);
-
-    if (opt_index < 0) {
-       /* diagnostics already printed */
-       return 1;
-    }
+    if (opt_index < 0)
+       return EXIT_FAILURE;
 
     if (output_file_name) {
        output = fopen (output_file_name, "w");
        if (output == NULL) {
            fprintf (stderr, "Error opening %s for writing: %s\n",
                     output_file_name, strerror (errno));
-           return 1;
+           return EXIT_FAILURE;
        }
     }
 
@@ -76,14 +69,14 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[])
        query_str = query_string_from_args (notmuch, argc - opt_index, argv + opt_index);
        if (query_str == NULL) {
            fprintf (stderr, "Out of memory.\n");
-           return 1;
+           return EXIT_FAILURE;
        }
     }
 
     query = notmuch_query_create (notmuch, query_str);
     if (query == NULL) {
        fprintf (stderr, "Out of memory\n");
-       return 1;
+       return EXIT_FAILURE;
     }
     /* Don't ask xapian to sort by Message-ID. Xapian optimizes returning the
      * first results quickly at the expense of total time.
@@ -102,6 +95,18 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[])
        message = notmuch_messages_get (messages);
        message_id = notmuch_message_get_message_id (message);
 
+       if (output_format == DUMP_FORMAT_BATCH_TAG &&
+           strchr (message_id, '\n')) {
+           /* This will produce a line break in the output, which
+            * would be difficult to handle in tools.  However, it's
+            * also impossible to produce an email containing a line
+            * break in a message ID because of unfolding, so we can
+            * safely disallow it. */
+           fprintf (stderr, "Warning: skipping message id containing line break: \"%s\"\n", message_id);
+           notmuch_message_destroy (message);
+           continue;
+       }
+
        if (output_format == DUMP_FORMAT_SUP) {
            fprintf (output, "%s (", message_id);
        }
@@ -123,7 +128,7 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[])
                                &buffer, &buffer_size) != HEX_SUCCESS) {
                    fprintf (stderr, "Error: failed to hex-encode tag %s\n",
                             tag_str);
-                   return 1;
+                   return EXIT_FAILURE;
                }
                fprintf (output, "+%s", buffer);
            }
@@ -132,13 +137,13 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[])
        if (output_format == DUMP_FORMAT_SUP) {
            fputs (")\n", output);
        } else {
-           if (hex_encode (notmuch, message_id,
-                           &buffer, &buffer_size) != HEX_SUCCESS) {
-                   fprintf (stderr, "Error: failed to hex-encode msg-id %s\n",
-                            message_id);
-                   return 1;
+           if (make_boolean_term (notmuch, "id", message_id,
+                                  &buffer, &buffer_size)) {
+                   fprintf (stderr, "Error quoting message id %s: %s\n",
+                            message_id, strerror (errno));
+                   return EXIT_FAILURE;
            }
-           fprintf (output, " -- id:%s\n", buffer);
+           fprintf (output, " -- %s\n", buffer);
        }
 
        notmuch_message_destroy (message);
@@ -150,5 +155,5 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[])
     notmuch_query_destroy (query);
     notmuch_database_destroy (notmuch);
 
-    return 0;
+    return EXIT_SUCCESS;
 }