]> git.notmuchmail.org Git - notmuch/blobdiff - notmuch-reply.c
Decode headers in reply
[notmuch] / notmuch-reply.c
index e85568c082ef8d519c1e391221e29867fc02d2aa..230cacc34fc539f1c1714ee83f0c86738a99ddbf 100644 (file)
 
 #include "notmuch-client.h"
 #include "gmime-filter-reply.h"
-
-static const struct {
-    const char *header;
-    const char *fallback;
-    GMimeRecipientType recipient_type;
-} reply_to_map[] = {
-    { "reply-to", "from", GMIME_RECIPIENT_TYPE_TO  },
-    { "to",         NULL, GMIME_RECIPIENT_TYPE_TO  },
-    { "cc",         NULL, GMIME_RECIPIENT_TYPE_CC  },
-    { "bcc",        NULL, GMIME_RECIPIENT_TYPE_BCC }
-};
+#include "gmime-filter-headers.h"
 
 static void
 reply_part_content (GMimeObject *part)
 {
     GMimeStream *stream_stdout = NULL, *stream_filter = NULL;
     GMimeDataWrapper *wrapper;
+    const char *charset;
 
+    charset = g_mime_object_get_content_type_parameter (part, "charset");
     stream_stdout = g_mime_stream_file_new (stdout);
     if (stream_stdout) {
        g_mime_stream_file_set_owner (GMIME_STREAM_FILE (stream_stdout), FALSE);
        stream_filter = g_mime_stream_filter_new(stream_stdout);
+        if (charset) {
+          g_mime_stream_filter_add(GMIME_STREAM_FILTER(stream_filter),
+                                   g_mime_filter_charset_new(charset, "UTF-8"));
+        }
     }
     g_mime_stream_filter_add(GMIME_STREAM_FILTER(stream_filter),
                             g_mime_filter_reply_new(TRUE));
@@ -56,6 +52,25 @@ reply_part_content (GMimeObject *part)
        g_object_unref(stream_stdout);
 }
 
+static void
+show_reply_headers (GMimeMessage *message)
+{
+    GMimeStream *stream_stdout = NULL, *stream_filter = NULL;
+
+    stream_stdout = g_mime_stream_file_new (stdout);
+    if (stream_stdout) {
+       g_mime_stream_file_set_owner (GMIME_STREAM_FILE (stream_stdout), FALSE);
+       stream_filter = g_mime_stream_filter_new(stream_stdout);
+       if (stream_filter) {
+               g_mime_stream_filter_add(GMIME_STREAM_FILTER(stream_filter),
+                                        g_mime_filter_headers_new());
+               g_mime_object_write_to_stream(GMIME_OBJECT(message), stream_filter);
+               g_object_unref(stream_filter);
+       }
+       g_object_unref(stream_stdout);
+    }
+}
+
 static void
 reply_part (GMimeObject *part, int *part_count)
 {
@@ -193,20 +208,174 @@ add_recipients_for_string (GMimeMessage *message,
     return add_recipients_for_address_list (message, config, type, list);
 }
 
+/* Does the address in the Reply-To header of 'message' already appear
+ * in either the 'To' or 'Cc' header of the message?
+ */
+static int
+reply_to_header_is_redundant (notmuch_message_t *message)
+{
+    const char *header, *addr;
+    InternetAddressList *list;
+    InternetAddress *address;
+    InternetAddressMailbox *mailbox;
+
+    header = notmuch_message_get_header (message, "reply-to");
+    if (*header == '\0')
+       return 0;
+
+    list = internet_address_list_parse_string (header);
+
+    if (internet_address_list_length (list) != 1)
+       return 0;
+
+    address = internet_address_list_get_address (list, 0);
+    if (INTERNET_ADDRESS_IS_GROUP (address))
+       return 0;
+
+    mailbox = INTERNET_ADDRESS_MAILBOX (address);
+    addr = internet_address_mailbox_get_addr (mailbox);
+
+    if (strstr (notmuch_message_get_header (message, "to"), addr) != 0 ||
+       strstr (notmuch_message_get_header (message, "cc"), addr) != 0)
+    {
+       return 1;
+    }
+
+    return 0;
+}
+
+/* Augments the recipients of reply from the headers of message.
+ *
+ * If any of the user's addresses were found in these headers, the first
+ * of these returned, otherwise NULL is returned.
+ */
+static const char *
+add_recipients_from_message (GMimeMessage *reply,
+                            notmuch_config_t *config,
+                            notmuch_message_t *message)
+{
+    struct {
+       const char *header;
+       const char *fallback;
+       GMimeRecipientType recipient_type;
+    } reply_to_map[] = {
+       { "reply-to", "from", GMIME_RECIPIENT_TYPE_TO  },
+       { "to",         NULL, GMIME_RECIPIENT_TYPE_TO  },
+       { "cc",         NULL, GMIME_RECIPIENT_TYPE_CC  },
+       { "bcc",        NULL, GMIME_RECIPIENT_TYPE_BCC }
+    };
+    const char *from_addr = NULL;
+    unsigned int i;
+
+    /* Some mailing lists munge the Reply-To header despite it being A Bad
+     * Thing, see http://www.unicom.com/pw/reply-to-harmful.html
+     *
+     * The munging is easy to detect, because it results in a
+     * redundant reply-to header, (with an address that already exists
+     * in either To or Cc). So in this case, we ignore the Reply-To
+     * field and use the From header. Thie ensures the original sender
+     * will get the reply even if not subscribed to the list. Note
+     * that the address in the Reply-To header will always appear in
+     * the reply.
+     */
+    if (reply_to_header_is_redundant (message)) {
+       reply_to_map[0].header = "from";
+       reply_to_map[0].fallback = NULL;
+    }
+
+    for (i = 0; i < ARRAY_SIZE (reply_to_map); i++) {
+       const char *addr, *recipients;
+
+       recipients = notmuch_message_get_header (message,
+                                                reply_to_map[i].header);
+       if ((recipients == NULL || recipients[0] == '\0') && reply_to_map[i].fallback)
+           recipients = notmuch_message_get_header (message,
+                                                    reply_to_map[i].fallback);
+
+       addr = add_recipients_for_string (reply, config,
+                                         reply_to_map[i].recipient_type,
+                                         recipients);
+       if (from_addr == NULL)
+           from_addr = addr;
+    }
+
+    return from_addr;
+}
+
+static const char *
+guess_from_received_header (notmuch_config_t *config, notmuch_message_t *message)
+{
+    const char *received,*primary;
+    char **other;
+    char *by,*mta,*ptr,*token;
+    char *domain=NULL;
+    char *tld=NULL;
+    const char *delim=". \t";
+    size_t i,other_len;
+
+    received = notmuch_message_get_header (message, "received");
+    by = strstr (received, " by ");
+    if (by && *(by+4)) {
+       /* sadly, the format of Received: headers is a bit inconsistent,
+        * depending on the MTA used. So we try to extract just the MTA
+        * here by removing leading whitespace and assuming that the MTA
+        * name ends at the next whitespace
+        * we test for *(by+4) to be non-'\0' to make sure there's something
+        * there at all - and then assume that the first whitespace delimited
+        * token that follows is the last receiving server
+        */
+       mta = strdup (by+4);
+       if (mta == NULL)
+           return NULL;
+       token = strtok(mta," \t");
+       if (token == NULL)
+           return NULL;
+       /* Now extract the last two components of the MTA host name
+        * as domain and tld
+        */
+       while ((ptr = strsep (&token, delim)) != NULL) {
+           if (*ptr == '\0')
+               continue;
+           domain = tld;
+           tld = ptr;
+       }
+
+       if (domain) {
+           /* recombine domain and tld and look for it among the configured
+            * email addresses
+            */
+           *(tld-1) = '.';
+           primary = notmuch_config_get_user_primary_email (config);
+           if (strcasestr (primary, domain)) {
+               free (mta);
+               return primary;
+           }
+           other = notmuch_config_get_user_other_email (config, &other_len);
+           for (i = 0; i < other_len; i++)
+               if (strcasestr (other[i], domain)) {
+                   free (mta);
+                   return other[i];
+               }
+       }
+
+       free (mta);
+    }
+
+    return NULL;
+}
+
 static int
 notmuch_reply_format_default(void *ctx, notmuch_config_t *config, notmuch_query_t *query)
 {
     GMimeMessage *reply;
     notmuch_messages_t *messages;
     notmuch_message_t *message;
-    const char *subject, *recipients, *from_addr = NULL;
+    const char *subject, *from_addr = NULL;
     const char *in_reply_to, *orig_references, *references;
-    char *reply_headers;
-    unsigned int i;
 
     for (messages = notmuch_query_search_messages (query);
-        notmuch_messages_has_more (messages);
-        notmuch_messages_advance (messages))
+        notmuch_messages_valid (messages);
+        notmuch_messages_move_to_next (messages))
     {
        message = notmuch_messages_get (messages);
 
@@ -218,26 +387,14 @@ notmuch_reply_format_default(void *ctx, notmuch_config_t *config, notmuch_query_
        }
 
        subject = notmuch_message_get_header (message, "subject");
-
        if (strncasecmp (subject, "Re:", 3))
            subject = talloc_asprintf (ctx, "Re: %s", subject);
        g_mime_message_set_subject (reply, subject);
 
-       for (i = 0; i < ARRAY_SIZE (reply_to_map); i++) {
-           const char *addr;
+       from_addr = add_recipients_from_message (reply, config, message);
 
-           recipients = notmuch_message_get_header (message,
-                                                    reply_to_map[i].header);
-           if ((recipients == NULL || recipients[0] == '\0') && reply_to_map[i].fallback)
-               recipients = notmuch_message_get_header (message,
-                                                        reply_to_map[i].fallback);
-
-           addr = add_recipients_for_string (reply, config,
-                                             reply_to_map[i].recipient_type,
-                                             recipients);
-           if (from_addr == NULL)
-               from_addr = addr;
-       }
+       if (from_addr == NULL)
+           from_addr = guess_from_received_header (config, message);
 
        if (from_addr == NULL)
            from_addr = notmuch_config_get_user_primary_email (config);
@@ -265,9 +422,7 @@ notmuch_reply_format_default(void *ctx, notmuch_config_t *config, notmuch_query_
        g_mime_object_set_header (GMIME_OBJECT (reply),
                                  "References", references);
 
-       reply_headers = g_mime_object_to_string (GMIME_OBJECT (reply));
-       printf ("%s", reply_headers);
-       free (reply_headers);
+       show_reply_headers (reply);
 
        g_object_unref (G_OBJECT (reply));
        reply = NULL;
@@ -290,13 +445,12 @@ notmuch_reply_format_headers_only(void *ctx, notmuch_config_t *config, notmuch_q
     GMimeMessage *reply;
     notmuch_messages_t *messages;
     notmuch_message_t *message;
-    const char *recipients, *in_reply_to, *orig_references, *references;
+    const char *in_reply_to, *orig_references, *references;
     char *reply_headers;
-    unsigned int i;
 
     for (messages = notmuch_query_search_messages (query);
-        notmuch_messages_has_more (messages);
-        notmuch_messages_advance (messages))
+        notmuch_messages_valid (messages);
+        notmuch_messages_move_to_next (messages))
     {
        message = notmuch_messages_get (messages);
 
@@ -310,31 +464,23 @@ notmuch_reply_format_headers_only(void *ctx, notmuch_config_t *config, notmuch_q
        in_reply_to = talloc_asprintf (ctx, "<%s>",
                             notmuch_message_get_message_id (message));
 
+        g_mime_object_set_header (GMIME_OBJECT (reply),
+                                 "In-Reply-To", in_reply_to);
+
+
        orig_references = notmuch_message_get_header (message, "references");
 
-       /* We print References first because git format-patch treats it specially.
-        * Git uses the first entry of References to create In-Reply-To.
+       /* We print In-Reply-To followed by References because git format-patch treats them
+         * specially.  Git does not interpret the other headers specially
         */
        references = talloc_asprintf (ctx, "%s%s%s",
-                                     in_reply_to,
                                      orig_references ? orig_references : "",
-                                     orig_references ? " " : "");
+                                     orig_references ? " " : "",
+                                     in_reply_to);
        g_mime_object_set_header (GMIME_OBJECT (reply),
                                  "References", references);
 
-       for (i = 0; i < ARRAY_SIZE (reply_to_map); i++) {
-           const char *addr;
-
-           recipients = notmuch_message_get_header (message,
-                                                    reply_to_map[i].header);
-           if ((recipients == NULL || recipients[0] == '\0') && reply_to_map[i].fallback)
-               recipients = notmuch_message_get_header (message,
-                                                        reply_to_map[i].fallback);
-
-           addr = add_recipients_for_string (reply, config,
-                                             reply_to_map[i].recipient_type,
-                                             recipients);
-       }
+       (void)add_recipients_from_message (reply, config, message);
 
        g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc",
                           notmuch_config_get_user_primary_email (config));