X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=blobdiff_plain;f=Makefile.local;h=53a4a94bd9e8b83ddc1f54f919012dee051e5bb8;hp=8207228476c2ab4cf0f7b7df0dd8919fef7da757;hb=2608bfe95f2c29ba568fa14904087882373971bc;hpb=2bf06e177db923b31f12faefb328b3bfe0651d6d

diff --git a/Makefile.local b/Makefile.local
index 82072284..53a4a94b 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -9,7 +9,7 @@
 # Between releases, (such as when compiling notmuch from the git
 # repository), we let git append identification of the actual commit.
 PACKAGE=notmuch
-VERSION:=$(shell if [ -f version ]; then cat version; else git describe --match '[0-9].[0-9]*'; fi)
+VERSION:=$(shell if [ -f version ]; then cat version; else git describe --match '[0-9.]*'; fi)
 
 RELEASE_HOST=notmuchmail.org
 RELEASE_DIR=/srv/notmuchmail.org/www/releases
@@ -69,7 +69,7 @@ dist: $(TAR_FILE)
 # We invoke make recursively only to force ordering of our phony
 # targets in the case of parallel invocation of make (-j).
 .PHONY: release
-release: verify-version
+release: verify-no-dirty-code
 	$(MAKE) test
 	$(MAKE) $(GPG_FILE)
 	$(MAKE) verify-newer
@@ -79,11 +79,8 @@ release: verify-version
 	mv $(TAR_FILE) $(SHA1_FILE) $(GPG_FILE) releases
 	git tag -s -m "$(PACKAGE) $(VERSION) release" $(VERSION)
 	git push origin $(VERSION)
-	@echo "Please send a release announcement as follows:"
-	@echo ""
-	$(MAKE) release-message
 	$(MAKE) release-message > $(PACKAGE)-$(VERSION).announce
-	@echo "(This message is also available in $(PACKAGE)-$(VERSION).announce"
+	@echo "Please send a release announcement using $(PACKAGE)-$(VERSION).announce as a template."
 
 .PHONY: release-message
 release-message:
@@ -105,7 +102,7 @@ release-message:
 	@echo ""
 	@echo "What's new in notmuch $(VERSION)"
 	@echo "========================="
-	@sed -ne '/^[Nn]otmuch 0.1/{n;n;b NEWS}; d; :NEWS /^===/q; {p;n;b NEWS}' < NEWS | head -n -2
+	@sed -ne '/^[Nn]otmuch $(VERSION)/{n;n;b NEWS}; d; :NEWS /^===/q; {p;n;b NEWS}' < NEWS | head -n -2
 	@echo ""
 	@echo "What is notmuch"
 	@echo "==============="
@@ -116,13 +113,32 @@ release-message:
 	@echo ""
 	@echo "For more about notmuch, see http://notmuchmail.org"
 
+.PHONY: verify-no-dirty-code
+verify-no-dirty-code: verify-version
+	@printf "Checking that source tree is clean..."
+ifneq ($(shell git ls-files -m),)
+	@echo "No"
+	@echo "The following files have been modified since the most recent git commit:"
+	@echo ""
+	@git ls-files -m
+	@echo ""
+	@echo "The release will be made from the committed state, but perhaps you meant"
+	@echo "to commit this code first? Please clean this up to make it more clear."
+	@false
+else
+	@echo "Good"
+endif
 
 .PHONY: verify-version
 verify-version:
-	@echo -n "Checking that $(VERSION) is a two-component version..."
-	@if echo $(VERSION) | grep -q -v -x '[0-9]*\.[0-9]*'; then \
-		(echo "Ouch." && \
-	         echo "Before releasing the notmuch version should be a two-component value." && false);\
+	@echo -n "Checking that $(VERSION) consists only of digits and periods..."
+	@if echo $(VERSION) | grep -q -v -x '[0-9.]*'; then \
+		(echo "No." && \
+	         echo "Remember: You need to use:" && \
+	         echo "" && \
+	         echo "	make VERSION=X.Y release" && \
+	         echo "" && \
+	         echo "to release notmuch." && false); \
 	 else :; fi
 	@echo "Good."