X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=blobdiff_plain;f=lib%2Fdatabase.cc;h=82c078867a52dee07a61dbaf6bea77044d578398;hp=dd1fc6378c48c8b435eab97a0cede52ebc975f0a;hb=d064bd696ccc443a7ece9cfc8816999c69943223;hpb=98845fdbb2a4acaa0036f8e2e998e726b18e6b13

diff --git a/lib/database.cc b/lib/database.cc
index dd1fc637..82c07886 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -24,7 +24,6 @@
 
 #include <sys/time.h>
 #include <signal.h>
-#include <xapian.h>
 
 #include <glib.h> /* g_free, GPtrArray, GHashTable */
 
@@ -57,8 +56,12 @@ typedef struct {
  *
  *	type:	mail
  *
- *	id:	Unique ID of mail, (from Message-ID header or generated
- *		as "notmuch-sha1-<sha1_sum_of_entire_file>.
+ *	id:	Unique ID of mail. This is from the Message-ID header
+ *		if present and not too long (see NOTMUCH_MESSAGE_ID_MAX).
+ *		If it's present and too long, then we use
+ *		"notmuch-sha1-<sha1_sum_of_message_id>".
+ *              If this header is not present, we use
+ *		"notmuch-sha1-<sha1_sum_of_entire_file>".
  *
  *	thread:	The ID of the thread to which the mail belongs
  *
@@ -145,9 +148,11 @@ typedef struct {
  *
  *	thread_id_*	A pre-allocated thread ID for a particular
  *			message. This is actually an arbitarily large
- *			family of metadata name. Any particular name
- *			is formed by concatenating "thread_id_" with a
- *			message ID. The value stored is a thread ID.
+ *			family of metadata name. Any particular name is
+ *			formed by concatenating "thread_id_" with a message
+ *			ID (or the SHA1 sum of a message ID if it is very
+ *			long---see description of 'id' in the mail
+ *			document). The value stored is a thread ID.
  *
  *			These thread ID metadata values are stored
  *			whenever a message references a parent message
@@ -179,7 +184,7 @@ typedef struct {
  * nearly universal to all mail messages).
  */
 
-prefix_t BOOLEAN_PREFIX_INTERNAL[] = {
+static prefix_t BOOLEAN_PREFIX_INTERNAL[] = {
     { "type",			"T" },
     { "reference",		"XREFERENCE" },
     { "replyto",		"XREPLYTO" },
@@ -188,14 +193,14 @@ prefix_t BOOLEAN_PREFIX_INTERNAL[] = {
     { "directory-direntry",	"XDDIRENTRY" },
 };
 
-prefix_t BOOLEAN_PREFIX_EXTERNAL[] = {
+static prefix_t BOOLEAN_PREFIX_EXTERNAL[] = {
     { "thread",			"G" },
     { "tag",			"K" },
     { "is",			"K" },
     { "id",			"Q" }
 };
 
-prefix_t PROBABILISTIC_PREFIX[]= {
+static prefix_t PROBABILISTIC_PREFIX[]= {
     { "from",			"XFROM" },
     { "to",			"XTO" },
     { "attachment",		"XATTACHMENT" },
@@ -334,6 +339,23 @@ find_document_for_doc_id (notmuch_database_t *notmuch, unsigned doc_id)
     return notmuch->xapian_db->get_document (doc_id);
 }
 
+/* Generate a compressed version of 'message_id' of the form:
+ *
+ *	notmuch-sha1-<sha1_sum_of_message_id>
+ */
+static char *
+_message_id_compressed (void *ctx, const char *message_id)
+{
+    char *sha1, *compressed;
+
+    sha1 = notmuch_sha1_of_string (message_id);
+
+    compressed = talloc_asprintf (ctx, "notmuch-sha1-%s", sha1);
+    free (sha1);
+
+    return compressed;
+}
+
 notmuch_message_t *
 notmuch_database_find_message (notmuch_database_t *notmuch,
 			       const char *message_id)
@@ -341,6 +363,9 @@ notmuch_database_find_message (notmuch_database_t *notmuch,
     notmuch_private_status_t status;
     unsigned int doc_id;
 
+    if (strlen (message_id) > NOTMUCH_MESSAGE_ID_MAX)
+	message_id = _message_id_compressed (notmuch, message_id);
+
     try {
 	status = _notmuch_database_find_unique_doc_id (notmuch, "id",
 						       message_id, &doc_id);
@@ -1217,7 +1242,11 @@ _notmuch_database_generate_thread_id (notmuch_database_t *notmuch)
 static char *
 _get_metadata_thread_id_key (void *ctx, const char *message_id)
 {
-    return talloc_asprintf (ctx, "thread_id_%s", message_id);
+    if (strlen (message_id) > NOTMUCH_MESSAGE_ID_MAX)
+	message_id = _message_id_compressed (ctx, message_id);
+
+    return talloc_asprintf (ctx, NOTMUCH_METADATA_THREAD_ID_PREFIX "%s",
+			    message_id);
 }
 
 /* Find the thread ID to which the message with 'message_id' belongs.
@@ -1270,7 +1299,7 @@ _resolve_message_id_to_thread_id (notmuch_database_t *notmuch,
 
     talloc_free (metadata_key);
 
-    return thread_id;
+    return talloc_strdup (ctx, thread_id);
 }
 
 static notmuch_status_t
@@ -1570,10 +1599,12 @@ notmuch_database_add_message (notmuch_database_t *notmuch,
 	    if (message_id == NULL)
 		message_id = talloc_strdup (message_file, header);
 
-	    /* Reject a Message ID that's too long. */
-	    if (message_id && strlen (message_id) + 1 > NOTMUCH_TERM_MAX) {
+	    /* If a message ID is too long, substitute its sha1 instead. */
+	    if (message_id && strlen (message_id) > NOTMUCH_MESSAGE_ID_MAX) {
+		char *compressed = _message_id_compressed (message_file,
+							   message_id);
 		talloc_free (message_id);
-		message_id = NULL;
+		message_id = compressed;
 	    }
 	}