X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=blobdiff_plain;f=tag-util.c;h=343c161f471aa827ff186df01e7c24afe71e5d06;hp=c5f585950921af59659dddf8d635c95ae1853a2c;hb=4e2c351c588ad74f4800ca0344232be90387c54a;hpb=f0dfda5c7797f9db81ce35d270fe0ac406c7fca1;ds=sidebyside diff --git a/tag-util.c b/tag-util.c index c5f58595..343c161f 100644 --- a/tag-util.c +++ b/tag-util.c @@ -31,14 +31,7 @@ line_error (tag_parse_status_t status, return status; } -/* - * Test tags for some forbidden cases. - * - * return: NULL if OK, - * explanatory message otherwise. - */ - -static const char * +const char * illegal_tag (const char *tag, notmuch_bool_t remove) { @@ -165,8 +158,6 @@ parse_tag_command_line (void *ctx, int argc, char **argv, int i; - tag_op_list_reset (tag_ops); - for (i = 0; i < argc; i++) { if (strcmp (argv[i], "--") == 0) { i++; @@ -181,7 +172,7 @@ parse_tag_command_line (void *ctx, int argc, char **argv, msg = illegal_tag (argv[i] + 1, is_remove); if (msg) { - fprintf (stderr, "Error: %s", msg); + fprintf (stderr, "Error: %s\n", msg); return TAG_PARSE_INVALID; } @@ -190,9 +181,9 @@ parse_tag_command_line (void *ctx, int argc, char **argv, *query_str = query_string_from_args (ctx, argc - i, &argv[i]); - if (*query_str == NULL || **query_str == '\0') { - fprintf (stderr, "Error: notmuch tag requires at least one search term.\n"); - return TAG_PARSE_INVALID; + if (*query_str == NULL) { + fprintf (stderr, "Out of memory.\n"); + return TAG_PARSE_OUT_OF_MEMORY; } return TAG_PARSE_SUCCESS;