]> git.notmuchmail.org Git - notmuch/commit
test: don't bail out of `run_emacs' too early when missing prereqs
authorPieter Praet <pieter@praet.org>
Sat, 14 Jan 2012 09:09:37 +0000 (10:09 +0100)
committerDavid Bremner <bremner@debian.org>
Mon, 16 Jan 2012 02:37:07 +0000 (22:37 -0400)
commit42e8f66edf91095bb87b3ee7713b94002ffd3edc
treeef58249ab47e7754c0e09bc7f0f2ab05a18ccb1d
parentef5c1d73f8e736425682dc4db0ce285e6e2de0f5
test: don't bail out of `run_emacs' too early when missing prereqs

When running the Emacs tests in verbose mode, only the first missing
prereq is reported because the `run_emacs' function is short-circuited
early:

  #+begin_example
    emacs: Testing emacs interface
     missing prerequisites: [0]  emacs(1)
     skipping test: [0]  Basic notmuch-hello view in emacs
     SKIP   [0]  Basic notmuch-hello view in emacs
  #+end_example

This can lead to situations reminiscent of "dependency hell", so instead
of returning based on each individual `test_require_external_prereq's exit
status, we now do so only after checking all the prereqs:

  #+begin_example
    emacs: Testing emacs interface
     missing prerequisites: [0]  dtach(1) emacs(1) emacsclient(1)
     skipping test: [0]  Basic notmuch-hello view in emacs
     SKIP   [0]  Basic notmuch-hello view in emacs
  #+end_example

Also added missing prereq for dtach(1).
test/test-lib.sh