]> git.notmuchmail.org Git - notmuch/commit
test: fix passwd_sanitize()
authorFelipe Contreras <felipe.contreras@gmail.com>
Sat, 1 May 2021 11:54:10 +0000 (06:54 -0500)
committerDavid Bremner <david@tethera.net>
Sun, 2 May 2021 00:13:23 +0000 (21:13 -0300)
commitff5f141bf205ad25e8ed4b8c9436b530f8ebf2be
tree3d3a4c05b1f2d78a8c0d7b82fb819ee8ec76cd50
parent6a20478abb517a8c6c046a1ff640fa02d118aa88
test: fix passwd_sanitize()

If any of the variables is empty the output is completely messed up,
because replace("", "FOO") puts "FOO" before every single character.

I don't have my full name configured, and this is what I get:

  USER_FULL_NAME=USER_FULL_NAME=USER_FULL_NAME USER_FULL_NAMEsUSER_FULL_NAMEtUSER_FULL_NAMEdUSER_FULL_NAMEoUSER_FULL_NAMEuUSER_FULL_NAMEtUSER_FULL_NAME USER_FULL_NAME=USER_FULL_NAME=USER_FULL_NAME

Let's check for empty strings before doing any replace.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
test/test-lib.sh