cli: modify mime_node_open to take new crypto struct as argument

This simplifies the interface considerably.

diff --git a/mime-node.c b/mime-node.c
index a5645e5cb99d7a0547d2f32c5c69b92e67c94891..67f4b1635be95cbc1657b50bf8113e2af2b1a0cb 100644 (file)
--- a/mime-node.c
+++ b/mime-node.c
@@ -57,8 +57,7 @@ _mime_node_context_free (mime_node_context_t *res)
 
 notmuch_status_t
 mime_node_open (const void *ctx, notmuch_message_t *message,
 
 notmuch_status_t
 mime_node_open (const void *ctx, notmuch_message_t *message,

-               notmuch_crypto_context_t *cryptoctx,
-               notmuch_bool_t decrypt, mime_node_t **root_out)
+               notmuch_crypto_t *crypto, mime_node_t **root_out)

 {
     const char *filename = notmuch_message_get_filename (message);
     mime_node_context_t *mctx;
 {
     const char *filename = notmuch_message_get_filename (message);
     mime_node_context_t *mctx;


@@ -110,8 +109,8 @@ mime_node_open (const void *ctx, notmuch_message_t *message,
        goto DONE;
     }
 
        goto DONE;
     }
 

-    mctx->cryptoctx = cryptoctx;
-    mctx->decrypt = decrypt;
+    mctx->cryptoctx = crypto->gpgctx;
+    mctx->decrypt = crypto->decrypt;

 
     /* Create the root node */
     root->part = GMIME_OBJECT (mctx->mime_message);
 
     /* Create the root node */
     root->part = GMIME_OBJECT (mctx->mime_message);

diff --git a/notmuch-client.h b/notmuch-client.h
index ead7fbd023a8b7229fd3201949db4de140273e77..962c747ff3fd8a215918a25b3d2c133c85a7e2e8 100644 (file)
--- a/notmuch-client.h
+++ b/notmuch-client.h
@@ -350,9 +350,10 @@ struct mime_node {
 };
 
 /* Construct a new MIME node pointing to the root message part of
 };
 
 /* Construct a new MIME node pointing to the root message part of

- * message.  If cryptoctx is non-NULL, it will be used to verify
- * signatures on any child parts.  If decrypt is true, then cryptoctx
- * will additionally be used to decrypt any encrypted child parts.
+ * message.  If crypto->gpgctx is non-NULL, it will be used to verify
+ * signatures on any child parts.  If crypto->decrypt is true, then
+ * crypto.gpgctx will additionally be used to decrypt any encrypted
+ * child parts.

  *
  * Return value:
  *
  *
  * Return value:
  *


@@ -364,8 +365,7 @@ struct mime_node {
  */
 notmuch_status_t
 mime_node_open (const void *ctx, notmuch_message_t *message,
  */
 notmuch_status_t
 mime_node_open (const void *ctx, notmuch_message_t *message,

-               notmuch_crypto_context_t *cryptoctx,
-               notmuch_bool_t decrypt, mime_node_t **node_out);
+               notmuch_crypto_t *crypto, mime_node_t **node_out);

 
 /* Return a new MIME node for the requested child part of parent.
  * parent will be used as the talloc context for the returned child
 
 /* Return a new MIME node for the requested child part of parent.
  * parent will be used as the talloc context for the returned child

diff --git a/notmuch-reply.c b/notmuch-reply.c
index 11f269f4c984938aa913f20ff2ab2e99a843a403..6f368c93206d152fdb93a29320a74217a51946ae 100644 (file)
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -575,8 +575,7 @@ notmuch_reply_format_default(void *ctx,
        g_object_unref (G_OBJECT (reply));
        reply = NULL;
 
        g_object_unref (G_OBJECT (reply));
        reply = NULL;
 

-       if (mime_node_open (ctx, message, params->crypto.gpgctx, params->crypto.decrypt,
-                           &root) == NOTMUCH_STATUS_SUCCESS) {
+       if (mime_node_open (ctx, message, &(params->crypto), &root) == NOTMUCH_STATUS_SUCCESS) {

            format_part_reply (root);
            talloc_free (root);
        }
            format_part_reply (root);
            talloc_free (root);
        }


@@ -605,8 +604,7 @@ notmuch_reply_format_json(void *ctx,
 
     messages = notmuch_query_search_messages (query);
     message = notmuch_messages_get (messages);
 
     messages = notmuch_query_search_messages (query);
     message = notmuch_messages_get (messages);

-    if (mime_node_open (ctx, message, params->crypto.gpgctx, params->crypto.decrypt,
-                       &node) != NOTMUCH_STATUS_SUCCESS)
+    if (mime_node_open (ctx, message, &(params->crypto), &node) != NOTMUCH_STATUS_SUCCESS)

        return 1;
 
     reply = create_reply_message (ctx, config, message, reply_all);
        return 1;
 
     reply = create_reply_message (ctx, config, message, reply_all);

diff --git a/notmuch-show.c b/notmuch-show.c
index cc509a6f5e779e1af9eb520349c985360837d94b..fb5e9b6057912b615eb9ffeff245086edf0cd642 100644 (file)
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -810,8 +810,7 @@ show_message (void *ctx,
     mime_node_t *root, *part;
     notmuch_status_t status;
 
     mime_node_t *root, *part;
     notmuch_status_t status;
 

-    status = mime_node_open (local, message, params->crypto.gpgctx,
-                            params->crypto.decrypt, &root);
+    status = mime_node_open (local, message, &(params->crypto), &root);

     if (status)
        goto DONE;
     part = mime_node_seek_dfs (root, (params->part < 0 ? 0 : params->part));
     if (status)
        goto DONE;
     part = mime_node_seek_dfs (root, (params->part < 0 ? 0 : params->part));