]> git.notmuchmail.org Git - notmuch/commitdiff
use EMPTY_STRING in _parent_via_in_reply_to
authorDavid Bremner <david@tethera.net>
Mon, 3 Sep 2018 15:26:10 +0000 (12:26 -0300)
committerDavid Bremner <david@tethera.net>
Thu, 6 Sep 2018 11:07:13 +0000 (08:07 -0300)
This is a review suggestion [1] of Tomi. I decided not to squash it
so that the code movement remains clear.

[1]: id:m2pnxxgf5q.fsf@guru.guru-group.fi

lib/thread.cc

index 62dbd3b345482ccb901b8c05c135238f35bc0264..4711319d2cf67618edfe7c74b78a0c940bbf9784 100644 (file)
@@ -402,7 +402,7 @@ _parent_via_in_reply_to (notmuch_thread_t *thread, notmuch_message_t *message) {
     THREAD_DEBUG("checking message = %s in_reply_to=%s\n",
                 notmuch_message_get_message_id (message), in_reply_to);
 
-    if (in_reply_to && strlen (in_reply_to) &&
+    if (in_reply_to && (! EMPTY_STRING(in_reply_to)) &&
        g_hash_table_lookup_extended (thread->message_hash,
                                      in_reply_to, NULL,
                                      (void **) &parent)) {