Fix folder: coherence issue

Add removal of all ZXFOLDER terms to removal of all XFOLDER terms for
each message filename removal.

The existing filename-list reindexing will put all the needed terms
back in.  Test search-folder-coherence now passes.

Signed-off-by:Mark Anderson <ma.skies@gmail.com>
(cherry picked from commit 8a856e5c38b79359e4fbf9e27f58b1fe00c1e18a)

diff --git a/lib/message.cc b/lib/message.cc
index 4b59fa9133f9cc45227bc8fbb63e0baeb3f7e7f3..2a4954dd59ce1d9c72fc0e2685459b730e79f699 100644 (file)
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -514,6 +514,8 @@ _notmuch_message_remove_filename (notmuch_message_t *message,
     const char *folder_prefix = _find_prefix ("folder");
     int folder_prefix_len = strlen (folder_prefix);
     void *local = talloc_new (message);
     const char *folder_prefix = _find_prefix ("folder");
     int folder_prefix_len = strlen (folder_prefix);
     void *local = talloc_new (message);

+    char *zfolder_prefix = talloc_asprintf(local, "Z%s", folder_prefix);
+    int zfolder_prefix_len = strlen (zfolder_prefix);

     char *direntry;
     notmuch_private_status_t private_status;
     notmuch_status_t status;
     char *direntry;
     notmuch_private_status_t private_status;
     notmuch_status_t status;


@@ -530,9 +532,12 @@ _notmuch_message_remove_filename (notmuch_message_t *message,
     status = COERCE_STATUS (private_status,
                            "Unexpected error from _notmuch_message_remove_term");
 
     status = COERCE_STATUS (private_status,
                            "Unexpected error from _notmuch_message_remove_term");
 

-    /* Re-synchronize "folder:" terms for this message. This requires
-     * first removing all "folder:" terms, then adding back terms for
-     * all remaining filenames of the message. */
+    /* Re-synchronize "folder:" terms for this message. This requires:
+     *  1. removing all "folder:" terms
+     *  2. removing all "folder:" stemmed terms
+     *  3. adding back terms for all remaining filenames of the message. */
+
+    /* 1. removing all "folder:" terms */

     while (1) {
        i = message->doc.termlist_begin ();
        i.skip_to (folder_prefix);
     while (1) {
        i = message->doc.termlist_begin ();
        i.skip_to (folder_prefix);


@@ -551,6 +556,26 @@ _notmuch_message_remove_filename (notmuch_message_t *message,
        }
     }
 
        }
     }
 

+    /* 2. removing all "folder:" stemmed terms */
+    while (1) {
+       i = message->doc.termlist_begin ();
+       i.skip_to (zfolder_prefix);
+
+       /* Terminate loop when no terms remain with desired prefix. */
+       if (i == message->doc.termlist_end () ||
+           strncmp ((*i).c_str (), zfolder_prefix, zfolder_prefix_len))
+       {
+           break;
+       }
+
+       try {
+           message->doc.remove_term ((*i));
+       } catch (const Xapian::InvalidArgumentError) {
+           /* Ignore failure to remove non-existent term. */
+       }
+    }
+
+    /* 3. adding back terms for all remaining filenames of the message. */

     i = message->doc.termlist_begin ();
     i.skip_to (direntry_prefix);
 
     i = message->doc.termlist_begin ();
     i.skip_to (direntry_prefix);