]> git.notmuchmail.org Git - notmuch/commitdiff
libnotmuch: export Xapian typeinfo symbols
authorDavid Bremner <bremner@debian.org>
Sat, 16 Jul 2011 18:59:44 +0000 (15:59 -0300)
committerDavid Bremner <bremner@debian.org>
Sun, 17 Jul 2011 01:16:46 +0000 (22:16 -0300)
The lack of such exporting seems to cause problems catching
exceptions, as suggested by

    http://gcc.gnu.org/wiki/Visibility

This manifested in the symbol-hiding test failing when notmuch was
compile with gcc 4.4.5. On i386, this further manifested as notmuch
new failing to run (crashing with an uncaught exception on first run).

lib/Makefile.local
lib/gen-version-script.sh [new file with mode: 0644]

index 7e2bc87be147734d0750ee345ac51556e9320575..a6076ab5df19fc38f77741a10ae81c2b70dd80af 100644 (file)
@@ -76,9 +76,7 @@ $(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym
        $(call quiet,CXX $(CXXFLAGS)) $(libnotmuch_modules) $(FINAL_LIBNOTMUCH_LDFLAGS) $(LIBRARY_LINK_FLAG) -o $@
 
 notmuch.sym: lib/notmuch.h
-       printf "{\nglobal:\n" > notmuch.sym
-       sed  -n 's/^\s*\(notmuch_[a-z_]*\)\s*(.*/\t\1;/p' $< >> notmuch.sym
-       printf "local: *;\n};\n" >> notmuch.sym
+       sh lib/gen-version-script.sh $< $(libnotmuch_modules) > $@
 
 $(dir)/$(SONAME): $(dir)/$(LIBNAME)
        ln -sf $(LIBNAME) $@
diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh
new file mode 100644 (file)
index 0000000..e753eaf
--- /dev/null
@@ -0,0 +1,27 @@
+
+# we go through a bit of work to get the unmangled names of the
+# typeinfo symbols because of
+# http://sourceware.org/bugzilla/show_bug.cgi?id=10326
+
+if [ $# -lt 2 ]; then
+    echo Usage: $0 header obj1 obj2 obj3
+    exit 1;
+fi
+
+HEADER=$1
+shift
+
+printf '{\nglobal:\n'
+nm --defined $* | awk '$3 ~ "Xapian.*Error" {print $3}' | sort | uniq | \
+while read sym; do
+    demangled=$(c++filt $sym)
+    case $demangled in
+       typeinfo*) 
+           printf "\t$sym;\n"
+           ;;
+       *)
+           ;;
+    esac
+done
+sed  -n 's/^\s*\(notmuch_[a-z_]*\)\s*(.*/\t\1;/p' $HEADER
+printf "local: *;\n};\n"