From: Michal Sojka <sojkam1@fel.cvut.cz>
Date: Mon, 26 May 2014 14:05:57 +0000 (+0200)
Subject: Make parsing of References and In-Reply-To header less error prone
X-Git-Tag: 0.19_rc1~105
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=028c56061e820211f5757a49bf4da30198b29e29;hp=028c56061e820211f5757a49bf4da30198b29e29

Make parsing of References and In-Reply-To header less error prone

According to RFC2822 References and In-Reply-To headers are supposed
to contain one or more Message-IDs, however older RFC822 allowed
almost any content. When both References and In-Reply-To headers ends
with something else that a Message-ID (see e.g. [1]), the thread
structure presented by notmuch is incorrect. The reason is that
notmuch treats this case as if the email contained no "replyto"
information (see _notmuch_database_link_message_to_parents).

This patch changes the parse_references() function to return the last
valid Message-ID encountered rather than NULL resulting from the last
hunk of text not being the Message-ID.

[1] https://lkml.org/lkml/headers/2014/5/19/864
---