From: Jani Nikula <jani@nikula.org>
Date: Sun, 1 Apr 2012 14:51:23 +0000 (+0300)
Subject: emacs: do not modify the alist passed to notmuch-sort-saved-searches
X-Git-Tag: 0.13_rc1~95
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=052000f85ae2e75efdf882a7fd15ef5698001c42

emacs: do not modify the alist passed to notmuch-sort-saved-searches

Sort modifies its input as a side effect. Pass it a copy in
notmuch-sort-saved-searches to not modify the notmuch-saved-searches
alist.
---

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 28f39f19..6b4b2c14 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -41,7 +41,7 @@
 
 (defun notmuch-sort-saved-searches (alist)
   "Generate an alphabetically sorted saved searches alist."
-  (sort alist (lambda (a b) (string< (car a) (car b)))))
+  (sort (copy-sequence alist) (lambda (a b) (string< (car a) (car b)))))
 
 (defcustom notmuch-saved-search-sort-function nil
   "Function used to sort the saved searches for the notmuch-hello view.