From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Fri, 17 Mar 2017 22:28:48 +0000 (+0200)
Subject: lib/message.cc: fix Coverity finding (use after free)
X-Git-Tag: 0.24.1~14
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=06adc276682d1d5f73d78df2e898ad4191eb4499;hp=06adc276682d1d5f73d78df2e898ad4191eb4499

lib/message.cc: fix Coverity finding (use after free)

The object where pointer to `data` was received was deleted before
it was used in _notmuch_string_list_append().

Relevant Coverity messages follow:

3: extract
Assigning: data = std::__cxx11::string(message->doc.()).c_str(),
which extracts wrapped state from temporary of type std::__cxx11::string.

4: dtor_free
The internal representation of temporary of type std::__cxx11::string
is freed by its destructor.

5: use after free:
Wrapper object use after free (WRAPPER_ESCAPE)
Using internal representation of destroyed object local data.
---