From: Michal Sojka <sojkam1@fel.cvut.cz>
Date: Wed, 6 Jan 2016 21:28:45 +0000 (+0100)
Subject: emacs: Don't use nconc on quoted list
X-Git-Tag: 0.22_rc0~81
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=10f4724a8d51a411d8f63d9449a38cd71bee6ae9

emacs: Don't use nconc on quoted list

As pointed out by David Bremner, Elisp manual says "A common pitfall
is to use a quoted constant list as a non-last argument to ‘nconc’."
Since this was the case in recently added code, we fix it here.
---

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 45a6daab..5462f543 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -322,8 +322,8 @@ modified. This function is notmuch addaptation of
   (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
 			     (or switch-function (notmuch-mua-get-switch-function)))
   (let ((headers
-	 ;; The following sexp is copied from `message-mail'
-	 (nconc
+	 (append
+	  ;; The following is copied from `message-mail'
 	  `((To . ,(or to "")) (Subject . ,(or subject "")))
 	  ;; C-h f compose-mail says that headers should be specified as
 	  ;; (string . value); however all the rest of message expects