From: Sebastian Spaeth Date: Thu, 16 Jun 2011 15:33:47 +0000 (+0200) Subject: Simplify (& fix) Message().__str__() X-Git-Tag: debian/0.6_254~23 X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=12d6f90e77d975be721b6878bf6bbf914d65a369 Simplify (& fix) Message().__str__() We were still using len(self.get_replies()) for the __str__ summary of a mail, but 1) len(Messages()) has just gone away 2) the number of replies can not be retrieved when we got the message via search_messages() anyway, and 3) it is likely quite expensive to pull all replies for all messages that we display a summary of. So we fix this by simplifying str(Message()) to omit the number of replies. Signed-off-by: Sebastian Spaeth --- diff --git a/bindings/python/notmuch/message.py b/bindings/python/notmuch/message.py index 706af476..68de5552 100644 --- a/bindings/python/notmuch/message.py +++ b/bindings/python/notmuch/message.py @@ -749,9 +749,7 @@ class Message(object): msg['from'] = self.get_header('from') msg['tags'] = str(self.get_tags()) msg['date'] = date.fromtimestamp(self.get_date()) - replies = self.get_replies() - msg['replies'] = len(replies) if replies is not None else 0 - return "%(from)s (%(date)s) (%(tags)s) %(replies)d replies" % (msg) + return "%(from)s (%(date)s) (%(tags)s)" % (msg) def get_message_parts(self):