From: Jani Nikula <jani@nikula.org>
Date: Sun, 3 Nov 2013 12:24:44 +0000 (+0200)
Subject: lib: do not leak the database in compaction
X-Git-Tag: 0.17_rc1~78
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=35ca5feb28a6e52851ba61ea63478ade40991558

lib: do not leak the database in compaction

Destroy instead of close the database after compaction, and also on
error path, to not leak the database.
---

diff --git a/lib/database.cc b/lib/database.cc
index 7a8702e2..eadf8a76 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -941,10 +941,12 @@ notmuch_database_compact (const char* path,
 	goto DONE;
     }
 
-    notmuch_database_close(notmuch);
-
 DONE:
+    if (notmuch)
+	notmuch_database_destroy (notmuch);
+
     talloc_free(local);
+
     return ret;
 }
 #else