From: David Bremner Date: Sun, 18 Dec 2011 03:16:51 +0000 (-0400) Subject: build-system: use a shell variable for TMPFILE in debian-snapshot X-Git-Tag: 0.11_rc1~22 X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=47b5797261f4d0f1dcf74e507452e120788964cf build-system: use a shell variable for TMPFILE in debian-snapshot Aaron Ecay points out in id:"1324136185-4509-1-git-send-email-aaronecay@gmail.com" that the mktemp in debian-snapshot: TMPFILE := $(shell mktemp) Is being evaluated for every target. As best I can tell, this is because make is evaluating the right hand side, even though it is not doing the assignment. Of course, it isn't quite as nice to edit with the line continuations, but it is ideomatic make. --- diff --git a/Makefile.local b/Makefile.local index 5108a0cc..97f397ff 100644 --- a/Makefile.local +++ b/Makefile.local @@ -139,15 +139,16 @@ pre-release: mv $(TAR_FILE) $(DEB_TAR_FILE) releases .PHONY: debian-snapshot -debian-snapshot: TMPFILE := $(shell mktemp) debian-snapshot: make VERSION=$(VERSION) clean - cp debian/changelog $(TMPFILE) - EDITOR=/bin/true dch -b -v $(VERSION)+1 -D UNRELEASED 'test build, not for upload' - echo '3.0 (native)' > debian/source/format - debuild -us -uc - mv -f $(TMPFILE) debian/changelog - echo '3.0 (quilt)' > debian/source/format + TMPFILE=$$(mktemp /tmp/notmuch.XXXXXX); \ + cp debian/changelog $${TMPFILE}; \ + EDITOR=/bin/true dch -b -v $(VERSION)+1 \ + -D UNRELEASED 'test build, not for upload'; \ + echo '3.0 (native)' > debian/source/format; \ + debuild -us -uc; \ + mv -f $${TMPFILE} debian/changelog; \ + echo '3.0 (quilt)' > debian/source/format .PHONY: release-message release-message: