From: David Bremner Date: Sun, 13 Nov 2016 12:52:17 +0000 (-0400) Subject: emacs: rename notmuch-address-completion-hook to notmuch-address-post-completion... X-Git-Tag: 0.24_rc0~94 X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=4817005bfc811500802a2a65fd5351658a3e5a7d;ds=sidebyside emacs: rename notmuch-address-completion-hook to notmuch-address-post-completion-functions Apparently it is a (not completely adhered to) emacs convention [1] that only hooks that don't take arguments end in 'hook' [1]: https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html --- diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el index 36c796f9..5b2beefe 100644 --- a/emacs/notmuch-address.el +++ b/emacs/notmuch-address.el @@ -98,7 +98,7 @@ to know how address selection is made by default." :group 'notmuch-send :group 'notmuch-external) -(defcustom notmuch-address-completion-hook nil +(defcustom notmuch-address-post-completion-functions nil "Functions called after completing address. The completed address is passed as an argument to each function. @@ -218,7 +218,7 @@ external commands." (push chosen notmuch-address-history) (delete-region beg end) (insert chosen) - (run-hook-with-args 'notmuch-address-completion-hook chosen)) + (run-hook-with-args 'notmuch-address-post-completion-functions chosen)) (message "No matches.") (ding)))) (t nil))) diff --git a/emacs/notmuch-company.el b/emacs/notmuch-company.el index 91c4804f..b0f97821 100644 --- a/emacs/notmuch-company.el +++ b/emacs/notmuch-company.el @@ -86,7 +86,7 @@ (match (if (string-match notmuch-company-last-prefix arg) (match-end 0) 0)) - (post-completion (run-hook-with-args 'notmuch-address-completion-hook arg)) + (post-completion (run-hook-with-args 'notmuch-address-post-completion-functions arg)) (no-cache t))))