From: Mark Walters Date: Tue, 2 Sep 2014 18:56:04 +0000 (+0100) Subject: emacs: jump: sort-order bugfix X-Git-Tag: 0.19_rc1~89 X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=5c4f6ed99bd10fa26162c46601714141adeb3fb5;hp=3d39d346d793b9bea0c23ae2c16600feab11ee19 emacs: jump: sort-order bugfix default-value needs its argument to be quoted. Slightly strangely default-value of 't or nil is 't or nil respectively so the code (default-value notmuch-search-oldest-first) just gives the current value of notmuch-search-oldest-first rather than intended default-value of this variable. The symptom is that if you are in a search buffer and use notmuch jump to run a saved search which does not have an explicitly set sort order then the sort order of the saved-search is inherited from the current search buffer rather than being the default search order. Thanks to Jani for finding the bug. --- diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index 5eb0949b..0193f8cd 100644 --- a/emacs/notmuch-jump.el +++ b/emacs/notmuch-jump.el @@ -51,7 +51,7 @@ fast way to jump to a saved search from anywhere in Notmuch." (case (plist-get saved-search :sort-order) (newest-first nil) (oldest-first t) - (otherwise (default-value notmuch-search-oldest-first))))) + (otherwise (default-value 'notmuch-search-oldest-first))))) (push (list key name `(lambda () (notmuch-search ',query ',oldest-first))) action-map)))))