From: Carl Worth <cworth@cworth.org>
Date: Sat, 28 Nov 2009 18:01:22 +0000 (-0800)
Subject: Avoid bogus internal error reporting duplicate In-Reply-To IDs.
X-Git-Tag: 0.1~295
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=64c8d6227a90ea6c37ea112ee20b14f16b9b46e7

Avoid bogus internal error reporting duplicate In-Reply-To IDs.

This error was tirggered with a debugging build via:

	make CXXFLAGS="-DDEBUG"

and reported by David Bremner. The actual error is that I'm an
idiot that doesn't know how to use strcmp's return value. Of
course, the strcmp interface scores a negative 7 on Rusty Russell
ranking of bad interfaces:

http://ozlabs.org/~rusty/index.cgi/tech/2008-04-01.html
---

diff --git a/lib/message.cc b/lib/message.cc
index 03b8c812..49519f1e 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -318,7 +318,7 @@ _notmuch_message_get_in_reply_to (notmuch_message_t *message)
     in_reply_to = *i;
 
     if (i != message->doc.termlist_end () &&
-	strncmp ((*i).c_str (), prefix, prefix_len))
+	strncmp ((*i).c_str (), prefix, prefix_len) == 0)
     {
        INTERNAL_ERROR ("Message %s has duplicate In-Reply-To IDs: %s and %s\n",
 			notmuch_message_get_message_id (message),