From: Mark Walters <markwalters1009@gmail.com>
Date: Wed, 5 Dec 2012 12:11:49 +0000 (+0000)
Subject: emacs: show: refresh buffer did not remove overlays
X-Git-Tag: 0.15_rc1~127
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=776e21d953326f1d7c3317215d11c53ad6eaaf08

emacs: show: refresh buffer did not remove overlays

Previously refreshing the notmuch show buffer did not remove overlays
which meant that if the user refreshed a message with images the
images would remain and then the new text was added after.

One might have guessed that erase-buffer would have removed them but
it seems not.  Thus force the removal of overlays with remove-overlays.
---

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 4d6c014b..20f89970 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1185,6 +1185,10 @@ reset based on the original query."
   (let ((inhibit-read-only t)
 	(state (unless reset-state
 		 (notmuch-show-capture-state))))
+    ;; erase-buffer does not seem to remove overlays, which can lead
+    ;; to weird effects such as remaining images, so remove them
+    ;; manually.
+    (remove-overlays)
     (erase-buffer)
     (notmuch-show-build-buffer)
     (if state