From: Mark Walters <markwalters1009@gmail.com>
Date: Wed, 21 May 2014 09:58:50 +0000 (+0100)
Subject: emacs: make sure tagging on an empty query is harmless
X-Git-Tag: 0.18.1~19
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=83f531ad7ee4b9e9aacac4f45148c39101f17ab8;hp=83f531ad7ee4b9e9aacac4f45148c39101f17ab8

emacs: make sure tagging on an empty query is harmless

Currently notmuch-tag throws a "wrong-type-argument stringp nil" if
passed a nil query-string. Catch this and provide a more useful error
message. This fixes a case in notmuch-tree (if you try to tag when at
the end of the buffer).

Secondly, as pointed out by David (dme)
`notmuch-search-find-stable-query-region' can return the query string
() if there are no messages in the region. This gets passed to notmuch
tag, and due to interactions in the optimize_query code in
notmuch-tag.c becomes, in the case tag-change is -inbox, "( () ) and
(tag:inbox)". This query matches some strange collection of messages
which then get archived. This should probably be fixed, but in any
case make `notmuch-search-find-stable-query-region' return a nil
query-string in this case.

This avoids data-loss (random tag removal) in this case.
---