From: Carl Worth Date: Tue, 27 Oct 2009 23:17:22 +0000 (-0700) Subject: notmuch_database_close: Explicitly flush the Xapian database. X-Git-Tag: 0.1~678 X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=854f82fb91ef9560259e4597d475747e948204d5;hp=b0190e59ac14851a0b79a00d58aad2e8febea92f notmuch_database_close: Explicitly flush the Xapian database. This would have helped with the recent bug causing "notmuch new" to not record any results in the database. I'm not sure why the explicit flush would be required, (shouldn't the destructor always ensure that things flush?), but perhaps some outstanding references from the leak prevented that. In any case, an explicit flush on close() seems to make sense. --- diff --git a/database.cc b/database.cc index 9831d79c..8d477eca 100644 --- a/database.cc +++ b/database.cc @@ -505,6 +505,8 @@ notmuch_database_open (const char *path) void notmuch_database_close (notmuch_database_t *notmuch) { + notmuch->xapian_db->flush (); + delete notmuch->query_parser; delete notmuch->xapian_db; talloc_free (notmuch);