From: Austin Clements <amdragon@MIT.EDU>
Date: Wed, 29 Jun 2011 07:10:54 +0000 (-0400)
Subject: new: Don't update DB mtime if FS mtime equals wall-clock time.
X-Git-Tag: 0.7_rc1~31
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=8c39e8d6fbc1202605494d481b27be6bcccaf500;hp=8c39e8d6fbc1202605494d481b27be6bcccaf500

new: Don't update DB mtime if FS mtime equals wall-clock time.

This fixes a race where multiple message deliveries in the same second
with an intervening notmuch new could result in messages being ignored
by notmuch (at least, until a later delivery forced a rescan).
Because mtimes only have second granularity, later deliveries in the
same second won't change the directory mtime, and hence won't trigger
notmuch new to rescan the directory.  This situation can only occur
when notmuch new is being run at the same second as the directory's
modification time, so simply don't update the saved mtime in this
case.

This very race happens all over the test suite, and is currently
compensated for with increment_mtime (and, occasionally, luck).  With
this change, increment_mtime becomes unnecessary.
---