From: Carl Worth <cworth@cworth.org>
Date: Thu, 1 Apr 2010 05:59:30 +0000 (-0700)
Subject: Makefiles: Eliminate shell for loops in rule definitions.
X-Git-Tag: 0.1~28
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=8c671a17c04a4fa2104864cea8d18e84a7b516e9;hp=7b52b2c318e449c73146bd48c7f32145f158f3f5

Makefiles: Eliminate shell for loops in rule definitions.

These just made the output look so ugly, and weren't actually making
the rule definitions any simpler. Good riddance.
---

diff --git a/Makefile.local b/Makefile.local
index 135d26e8..2efef415 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -105,11 +105,10 @@ notmuch.1.gz: notmuch.1
 	$(call quiet,gzip) --stdout $^ > $@
 
 install: all notmuch.1.gz
-	for d in $(DESTDIR)$(prefix)/bin/ $(DESTDIR)$(libdir)/ \
-		$(DESTDIR)$(prefix)/include/ $(DESTDIR)$(prefix)/share/man/man1 ; \
-	do \
-		install -d $$d ; \
-	done ;
+	install -d $(DESTDIR)$(prefix)/bin/
+	install -d $(DESTDIR)$(libdir)/
+	install -d $(DESTDIR)$(prefix)/include/
+	install -d $(DESTDIR)$(prefix)/share/man/man1
 	install notmuch $(DESTDIR)$(prefix)/bin/
 	install -m0644 notmuch.1.gz $(DESTDIR)$(prefix)/share/man/man1/
 ifeq ($(MAKECMDGOALS), install)
diff --git a/emacs/Makefile.local b/emacs/Makefile.local
index 17ede863..6e7d2afd 100644
--- a/emacs/Makefile.local
+++ b/emacs/Makefile.local
@@ -6,14 +6,8 @@ emacs_bytecode := $(subst .el,.elc,$(emacs_sources))
 emacs: $(emacs_bytecode)
 
 install-emacs: install emacs
-	for d in $(DESTDIR)/$(emacs_lispdir) ; \
-	do \
-		install -d $$d ; \
-	done ;
-	for f in $(emacs_sources) $(emacs_bytecode); \
-	do \
-		install -m0644 $$f $(DESTDIR)$(emacs_lispdir) ;\
-	done;
+	install -d $(DESTDIR)/$(emacs_lispdir)
+	install -m0644 $(emacs_sources) $(emacs_bytecode) $(DESTDIR)$(emacs_lispdir)
 	@echo ""
 	@echo "The notmuch emacs client is now installed."
 	@echo ""