From: Carl Worth Date: Wed, 18 Nov 2009 02:37:45 +0000 (-0800) Subject: message_file_get_header: Use break where more clear than continue. X-Git-Tag: 0.1~464 X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=8cf72920e11c950fe7ae76cb762f79506aa8acfe;hp=d025e89ac7ccecc9a6bbea5e867fcc15589f81b5;ds=sidebyside message_file_get_header: Use break where more clear than continue. Calling continue here worked only because we set a flag before the continue, and, check the flag at the beginning of the loop, and *then* break. It's much more clear to just break in the first place. --- diff --git a/lib/message-file.c b/lib/message-file.c index 197ab014..3a1a681d 100644 --- a/lib/message-file.c +++ b/lib/message-file.c @@ -282,7 +282,7 @@ notmuch_message_file_get_header (notmuch_message_file_t *message, message->good_headers < 5) { message->parsing_finished = 1; - continue; + break; } NEXT_HEADER_LINE (NULL); continue;