From: Mark Walters <markwalters1009@gmail.com>
Date: Sun, 9 Dec 2012 20:17:29 +0000 (+0000)
Subject: contrib: pick: bugfix for pick splitting the window excessively
X-Git-Tag: 0.15_rc1~101
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=8f1a8c7b094e22e10cf88193d5243e62ae9c8da8;ds=sidebyside

contrib: pick: bugfix for pick splitting the window excessively

Previously if you carried on past the last message in a pick view pick
would get confused and `forget' about the split pane and would try and
re-split when moving up again. This was due to faulty logic in
notmuch-pick-show-message: something that should have been in the (when message)
clause was not.

Thanks to jrollins for the bug report.
---

diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 755cbbce..cf026af3 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -339,8 +339,8 @@ Does NOT change the database."
       (with-selected-window notmuch-pick-message-window
 	(setq current-prefix-arg '(4))
 	(setq buffer (notmuch-show id nil nil nil)))
-      (notmuch-pick-tag-update-display (list "-unread")))
-    (setq notmuch-pick-message-buffer buffer)))
+      (notmuch-pick-tag-update-display (list "-unread"))
+      (setq notmuch-pick-message-buffer buffer))))
 
 (defun notmuch-pick-show-message-out ()
   "Show the current message (in whole window)."