From: David Bremner <david@tethera.net>
Date: Sat, 13 Feb 2016 17:11:18 +0000 (-0400)
Subject: STYLE: document some rules about variable declarations
X-Git-Tag: 0.22_rc0~50
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=99a0a90f65f5a98d2562e36b48b3e423233c2eb4

STYLE: document some rules about variable declarations

No-one seemed opposed to C99 style loop variable declarations. The
requirement to declare variables at the top of blocks is maybe a little
more contested, but I believe it reflects the status quo.
---

diff --git a/devel/STYLE b/devel/STYLE
index 24bd5482..b22d8d35 100644
--- a/devel/STYLE
+++ b/devel/STYLE
@@ -25,9 +25,7 @@ The following nonsense code demonstrates many aspects of the style:
 static some_type
 function (param_type param, param_type param)
 {
-   int i;
-
-   for (i = 0; i < 10; i++) {
+   for (int i = 0; i < 10; i++) {
        int j;
 
        j = i + 10;
@@ -64,6 +62,9 @@ function (param_type param, param_type param)
 * Code lines should be less than 80 columns and comments should be
   wrapped at 70 columns.
 
+* Variable declarations should be at the top of a block; C99 style
+  control variable declarations in for loops are also OK.
+
 Naming
 ------