From: Carl Worth <cworth@cworth.org>
Date: Thu, 3 Dec 2009 18:39:33 +0000 (-0800)
Subject: emacs: notmuch-fontify-headers: Remove unneeded progn and indent correctly.
X-Git-Tag: 0.1~239
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=a0439ded70b69978b982a8defa48848780aba518

emacs: notmuch-fontify-headers: Remove unneeded progn and indent correctly.

The defun special form doesn't require a progn. And the remainder
of the function was previously indented in a misleading way, (as
if each "if" was always evaluated, rather than each only being
evaluated if all the previous evaluated to nil).
---

diff --git a/notmuch.el b/notmuch.el
index 6d7228fb..b3f67d2b 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -697,33 +697,32 @@ which this thread was originally shown."
       )))
 
 (defun notmuch-fontify-headers ()
-  (progn
-    (while (looking-at "[[:space:]]")
-      (forward-char))
-    (if (looking-at "[Tt]o:")
-	(progn
-	  (overlay-put (make-overlay (point) (re-search-forward ":"))
-                       'face 'message-header-name)
-          (overlay-put (make-overlay (point) (re-search-forward ".*$"))
-                       'face 'message-header-to))
+  (while (looking-at "[[:space:]]")
+    (forward-char))
+  (if (looking-at "[Tt]o:")
+      (progn
+	(overlay-put (make-overlay (point) (re-search-forward ":"))
+		     'face 'message-header-name)
+	(overlay-put (make-overlay (point) (re-search-forward ".*$"))
+		     'face 'message-header-to))
     (if (looking-at "[B]?[Cc][Cc]:")
 	(progn
 	  (overlay-put (make-overlay (point) (re-search-forward ":"))
-                       'face 'message-header-name)
-          (overlay-put (make-overlay (point) (re-search-forward ".*$"))
-                       'face 'message-header-cc))
-    (if (looking-at "[Ss]ubject:")
-	(progn
-	  (overlay-put (make-overlay (point) (re-search-forward ":"))
-                       'face 'message-header-name)
-          (overlay-put (make-overlay (point) (re-search-forward ".*$"))
-                       'face 'message-header-subject))
-    (if (looking-at "[Ff]rom:")
-	(progn
-	  (overlay-put (make-overlay (point) (re-search-forward ":"))
-                       'face 'message-header-name)
-          (overlay-put (make-overlay (point) (re-search-forward ".*$"))
-                       'face 'message-header-other))))))))
+		       'face 'message-header-name)
+	  (overlay-put (make-overlay (point) (re-search-forward ".*$"))
+		       'face 'message-header-cc))
+      (if (looking-at "[Ss]ubject:")
+	  (progn
+	    (overlay-put (make-overlay (point) (re-search-forward ":"))
+			 'face 'message-header-name)
+	    (overlay-put (make-overlay (point) (re-search-forward ".*$"))
+			 'face 'message-header-subject))
+	(if (looking-at "[Ff]rom:")
+	    (progn
+	      (overlay-put (make-overlay (point) (re-search-forward ":"))
+			   'face 'message-header-name)
+	      (overlay-put (make-overlay (point) (re-search-forward ".*$"))
+			   'face 'message-header-other)))))))
 
 (defun notmuch-show-markup-header (depth)
   (re-search-forward notmuch-show-header-begin-regexp)