From: David Bremner <david@tethera.net>
Date: Wed, 7 Jul 2021 01:51:08 +0000 (-0300)
Subject: emacs: remove useless lexically bound variable
X-Git-Tag: archive/debian/0.33_rc0-1~25
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=bed62eb8bee4aeca1fabfa5e302b515849f50b31

emacs: remove useless lexically bound variable

A let binding without a value is just an obfuscated way of saying
nil, especially if you are not going to mutate the variable.
---

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index b288c05d..eb7ea941 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -1001,10 +1001,9 @@ message together with all its descendents."
 
 (defun notmuch-tree-insert-forest-thread (forest-thread)
   "Insert a single complete thread."
-  (let (tree-status)
-    ;; Reset at the start of each main thread.
-    (setq notmuch-tree-previous-subject nil)
-    (notmuch-tree-insert-thread forest-thread 0 tree-status)))
+  ;; Reset at the start of each main thread.
+  (setq notmuch-tree-previous-subject nil)
+  (notmuch-tree-insert-thread forest-thread 0 nil))
 
 (defun notmuch-tree-insert-forest (forest)
   "Insert a forest of threads.