From: Jani Nikula <jani@nikula.org>
Date: Tue, 30 Oct 2012 20:32:32 +0000 (+0200)
Subject: build: drop the -Wswitch-enum warning
X-Git-Tag: 0.15_rc1~198
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=c158201ee217740cb1b64858df8c7d39cf7793d0;hp=42391b405610f48d81a369e899d0be9c9b0ee969

build: drop the -Wswitch-enum warning

-Wswitch-enum is a bit awkward if a switch statement is intended to
handle just some of the named codes of an enumeration especially, and
leave the rest to the default label.

We already have -Wall, which enables -Wswitch by default, and per GCC
documentation, "The only difference between -Wswitch and this option
[-Wswitch-enum] is that this option gives a warning about an omitted
enumeration code even if there is a default label."

Drop -Wswitch-enum to not force listing all named codes of
enumerations in switch statements that have a default label.
---

diff --git a/configure b/configure
index 232d8477..ea8a1ad5 100755
--- a/configure
+++ b/configure
@@ -536,7 +536,7 @@ fi
 
 WARN_CXXFLAGS=""
 printf "Checking for available C++ compiler warning flags... "
-for flag in -Wall -Wextra -Wwrite-strings -Wswitch-enum; do
+for flag in -Wall -Wextra -Wwrite-strings; do
     if ${CC} $flag -o minimal minimal.c > /dev/null 2>&1
     then
 	WARN_CXXFLAGS="${WARN_CXXFLAGS}${WARN_CXXFLAGS:+ }${flag}"