From: Piotr Trojanek <piotr.trojanek@gmail.com>
Date: Fri, 16 Jun 2017 22:50:23 +0000 (+0100)
Subject: fix leaks due to missing invocations of va_end
X-Git-Tag: 0.25_rc0~55
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=e9d73f90a6d3945b7ebda9d95ec719e0ba0c9756

fix leaks due to missing invocations of va_end

As the Linux man page states: "Each invocation of va_start() must be
matched by a corresponding invocation of va_end() in the same
function." Detected by cppcheck.
---

diff --git a/tag-util.c b/tag-util.c
index 7091d294..30c2c077 100644
--- a/tag-util.c
+++ b/tag-util.c
@@ -28,6 +28,9 @@ line_error (tag_parse_status_t status,
     fprintf (stderr, status < 0 ? "Error: " : "Warning: ");
     vfprintf (stderr, format, va_args);
     fprintf (stderr, " [%s]\n", line);
+
+    va_end (va_args);
+
     return status;
 }
 
@@ -200,6 +203,8 @@ message_error (notmuch_message_t *message,
     vfprintf (stderr, format, va_args);
     fprintf (stderr, "Message-ID: %s\n", notmuch_message_get_message_id (message));
     fprintf (stderr, "Status: %s\n", notmuch_status_to_string (status));
+
+    va_end (va_args);
 }
 
 static int