From: Justus Winter <4winter@informatik.uni-hamburg.de>
Date: Sat, 17 Mar 2012 16:41:27 +0000 (+0100)
Subject: Fix error reporting in notmuch_database_find_message_by_filename
X-Git-Tag: debian/0.12_rc2-1~3
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=ea54c4fdc7d0ed9a4d6ab328d44c10ce5668d587;ds=sidebyside

Fix error reporting in notmuch_database_find_message_by_filename

Formerly it was possible for *message_ret to be left
uninitialized. The documentation however clearly states that "[o]n any
failure or when the message is not found, this function initializes
'*message' to NULL".

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
---

diff --git a/lib/database.cc b/lib/database.cc
index 8f8df1a1..16c4354f 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -1825,6 +1825,9 @@ notmuch_database_find_message_by_filename (notmuch_database_t *notmuch,
     if (message_ret == NULL)
 	return NOTMUCH_STATUS_NULL_POINTER;
 
+    /* return NULL on any failure */
+    *message_ret = NULL;
+
     local = talloc_new (notmuch);
 
     try {