From: David Bremner Date: Sun, 12 May 2019 02:45:59 +0000 (-0600) Subject: test/emacs: revert invalid-from test to pre-86f89385 behaviour X-Git-Tag: archive/debian/0.29_rc0-1~49 X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=f4708ce0b1a8a7a4ae73b7e24768d81741f09d8c;hp=30c4fa3702f90572afcd1984dbd7aba70f2b4fd9 test/emacs: revert invalid-from test to pre-86f89385 behaviour To the best of my understanding, this original behaviour was what Carl's homebrew parser produced. With commit 86f89385 Austin switched to using GMime (2.6). This produced arguably worse results, but since the input was bad, we could live with it. Now with GMime 3.0 we are getting the original results again, and there is no reason to consider this test broken. --- diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh index c06a8133..5f74305d 100755 --- a/test/T310-emacs.sh +++ b/test/T310-emacs.sh @@ -86,14 +86,13 @@ test_emacs "(let ((notmuch-show-indent-messages-width 4)) test_expect_equal_file $EXPECTED/notmuch-show-thread-maildir-storage-with-fourfold-indentation OUTPUT test_begin_subtest "notmuch-show for message with invalid From" -test_subtest_known_broken add_message "[subject]=\"message-with-invalid-from\"" \ "[from]=\"\\\"Invalid \\\" From\\\" \"" thread=$(notmuch search --output=threads subject:message-with-invalid-from) test_emacs "(notmuch-show \"$thread\") (test-output \"OUTPUT.raw\")" cat <EXPECTED -"Invalid " (2001-01-05) (inbox) +Invalid " From (2001-01-05) (inbox) Subject: message-with-invalid-from To: Notmuch Test Suite Date: GENERATED_DATE