From: Carl Worth <cworth@cworth.org>
Date: Wed, 21 Oct 2009 05:08:31 +0000 (-0700)
Subject: Rename our talloc destructor functions to _destructor.
X-Git-Tag: 0.1~807
X-Git-Url: https://git.notmuchmail.org/git?p=notmuch;a=commitdiff_plain;h=f6c7810945f1bc25b15dee72257c3b68bd0e8a40;hp=466a7bbf620e4bf1b57097a6d3c474159c475b6d

Rename our talloc destructor functions to _destructor.

I want to reserve the _destroy names for some public functions
I'm about to add.
---

diff --git a/message.cc b/message.cc
index 5d99321d..cc157c8b 100644
--- a/message.cc
+++ b/message.cc
@@ -32,8 +32,14 @@ struct _notmuch_tags {
     Xapian::TermIterator iterator_end;
 };
 
+/* We end up having to call the destructor explicitly because we had
+ * to use "placement new" in order to initialize C++ objects within a
+ * block that we allocated with talloc. So C++ is making talloc
+ * slightly less simple to use, (we wouldn't need
+ * talloc_set_destructor at all otherwise).
+ */
 static int
-_notmuch_message_destroy (notmuch_message_t *message)
+_notmuch_message_destructor (notmuch_message_t *message)
 {
     message->doc.~Document ();
 
@@ -53,7 +59,7 @@ _notmuch_message_create (notmuch_results_t *owner,
 
     new (&message->doc) Xapian::Document;
 
-    talloc_set_destructor (message, _notmuch_message_destroy);
+    talloc_set_destructor (message, _notmuch_message_destructor);
 
     message->doc = notmuch->xapian_db->get_document (doc_id);
 
@@ -73,8 +79,14 @@ notmuch_message_get_message_id (notmuch_message_t *message)
 	return NULL;
 }
 
+/* We end up having to call the destructors explicitly because we had
+ * to use "placement new" in order to initialize C++ objects within a
+ * block that we allocated with talloc. So C++ is making talloc
+ * slightly less simple to use, (we wouldn't need
+ * talloc_set_destructor at all otherwise).
+ */
 static int
-_notmuch_tags_destroy (notmuch_tags_t *tags)
+_notmuch_tags_destructor (notmuch_tags_t *tags)
 {
     tags->iterator.~TermIterator ();
     tags->iterator_end.~TermIterator ();
@@ -94,7 +106,7 @@ notmuch_message_get_tags (notmuch_message_t *message)
     new (&tags->iterator) Xapian::TermIterator;
     new (&tags->iterator_end) Xapian::TermIterator;
 
-    talloc_set_destructor (tags, _notmuch_tags_destroy);
+    talloc_set_destructor (tags, _notmuch_tags_destructor);
 
     tags->iterator = message->doc.termlist_begin ();
     tags->iterator.skip_to ("L");
diff --git a/query.cc b/query.cc
index d3614dc3..c669fb91 100644
--- a/query.cc
+++ b/query.cc
@@ -66,8 +66,14 @@ notmuch_query_set_sort (notmuch_query_t *query, notmuch_sort_t sort)
     query->sort = sort;
 }
 
+/* We end up having to call the destructors explicitly because we had
+ * to use "placement new" in order to initialize C++ objects within a
+ * block that we allocated with talloc. So C++ is making talloc
+ * slightly less simple to use, (we wouldn't need
+ * talloc_set_destructor at all otherwise).
+ */
 static int
-_notmuch_results_destroy (notmuch_results_t *results)
+_notmuch_results_destructor (notmuch_results_t *results)
 {
     results->iterator.~PostingIterator ();
     results->iterator_end.~PostingIterator ();
@@ -94,7 +100,7 @@ notmuch_query_search (notmuch_query_t *query)
 	new (&results->iterator) Xapian::PostingIterator ();
 	new (&results->iterator_end) Xapian::PostingIterator ();
 
-	talloc_set_destructor (results, _notmuch_results_destroy);
+	talloc_set_destructor (results, _notmuch_results_destructor);
 
 	results->iterator = query->notmuch->xapian_db->postlist_begin ("");
 	results->iterator_end = query->notmuch->xapian_db->postlist_end ("");