From 105537a809d1a385a3151de0c5b6235773782040 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 2 Jan 2015 17:18:42 +0100 Subject: [PATCH] lib: convert two "iterator copy strings" into references. Apparently this is a supported and even idiomatic way of keeping a temporary object (e.g. like that returned from an operator dereference) alive. --- lib/message.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index bacb4d46..956a70a9 100644 --- a/lib/message.cc +++ b/lib/message.cc @@ -283,7 +283,7 @@ _notmuch_message_get_term (notmuch_message_t *message, if (i == end) return NULL; - std::string term = *i; + const std::string &term = *i; if (strncmp (term.c_str(), prefix, prefix_len)) return NULL; @@ -641,7 +641,7 @@ _notmuch_message_add_directory_terms (void *ctx, notmuch_message_t *message) unsigned int directory_id; const char *direntry, *directory; char *colon; - const std::string term = *i; + const std::string &term = *i; /* Terminate loop at first term without desired prefix. */ if (strncmp (term.c_str (), direntry_prefix, direntry_prefix_len)) -- 2.43.0