From 9f05ceb994d1d674cf2f433f0d794b671fef38ec Mon Sep 17 00:00:00 2001 From: Daniel Kahn Gillmor Date: Sat, 4 May 2019 17:33:26 -0400 Subject: [PATCH] test/crypto: clarify the difference between ownertrust and validity This is a subtle difference, but the output of notmuch shouldn't ever change based on ownertrust itself -- notmuch is intended to show valid User IDs, and to avoid showing invalid User IDs. It so happens that setting ownertrust of a key to ultimate sets all associated user IDs to "full" validity, so the test is correct, but just misnamed. Signed-off-by: Daniel Kahn Gillmor --- test/T350-crypto.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh index 6045a7dc..bd369f8f 100755 --- a/test/T350-crypto.sh +++ b/test/T350-crypto.sh @@ -135,8 +135,9 @@ test_expect_equal_json \ "$output" \ "$expected" -test_begin_subtest "signature verification with full owner trust" -# give the key full owner trust +test_begin_subtest "signature verification with full user ID validity" +# give the key ultimate owner trust, which confers full validity on +# all user IDs in the certificate: echo "${FINGERPRINT}:6:" | gpg --no-tty --import-ownertrust >>"$GNUPGHOME"/trust.log 2>&1 gpg --no-tty --check-trustdb >>"$GNUPGHOME"/trust.log 2>&1 output=$(notmuch show --format=json --verify subject:"test signed message 001" \ -- 2.43.0