From a6b93ef32b3274f0ae51acc336500a439371d0fc Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Fri, 3 Jun 2011 10:01:06 -0700 Subject: [PATCH] Do not attempt to output part raw if part is not GMimePart. This was a minor oversite in checking of part type when outputing content raw. This was causing gmime was to throw an exception to stderr. Unfortunately the gmime exception was not being caught by notmuch, or the test suite. I'm not sure if notmuch should have done anything in this case, but certainly the test suite should be capable of detecting that something unexpected was output to stderr. --- notmuch-show.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/notmuch-show.c b/notmuch-show.c index dbb1efb9..912999e1 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -708,6 +708,9 @@ format_part_end_json (GMimeObject *part) static void format_part_content_raw (GMimeObject *part) { + if (! GMIME_IS_PART (part)) + return; + GMimeStream *stream_stdout; GMimeStream *stream_filter = NULL; GMimeDataWrapper *wrapper; -- 2.43.0